Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Conflict with .container Class in LABJS #226

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Resolve Conflict with .container Class in LABJS #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c3755
Fixed container class issue
Axthauvin Feb 11, 2024
cb5b6b8
Update index.html
Axthauvin Feb 11, 2024
a9032ea
Update lab.css
Axthauvin Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/library/src/starterkit/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<body>
<!-- If you'd rather have a container with a fixed width
and variable height, try removing the fullscreen class below -->
<div class="container fullscreen">
<div class="labjs-container fullscreen">
<header class="content-vertical-center content-horizontal-center">
<div>
<!-- You could put a title here,
Expand Down
20 changes: 10 additions & 10 deletions packages/library/src/starterkit/lib/lab.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ body {
background: var(--color-background);
}

.container {
.labjs-container {
min-width: var(--width-min-container);
min-height: var(--height-min-header-footer);
/* Use page-style layout by default */
Expand Down Expand Up @@ -85,7 +85,7 @@ main {
}

/* Fullscreen layout */
.container.fullscreen {
.labjs-container.fullscreen {
/* Full screen minus margins */
margin: var(--padding-internal);
min-height: calc(100vh - 2 * var(--padding-internal));
Expand All @@ -94,26 +94,26 @@ main {
display: flex;
flex-direction: column;
}
.container.fullscreen main {
.labjs-container.fullscreen main {
/* Flex positioning */
flex: 1;
}

/* Frameless layout */
.container.frameless {
.labjs-container.frameless {
margin: 0 auto;
border: none;
border-radius: 0;
}
.container.fullscreen.frameless {
.labjs-container.fullscreen.frameless {
margin: 0;
width: 100%;
min-height: 100vh;
}

/* Remove frame on small screens */
@media (max-width: 600px), (max-height: 600px) {
.container.fullscreen {
.labjs-container.fullscreen {
margin: 0;
border: none;
border-radius: 0;
Expand All @@ -123,7 +123,7 @@ main {
}

/* Borders and backgrounds */
.container {
.labjs-container {
border: 1px solid var(--color-border);
border-radius: var(--border-radius-container);
}
Expand Down Expand Up @@ -475,12 +475,12 @@ table .sticky-top {
}

/* Width, for some reason, needs to be set explicitly */
.container.fullscreen .popover {
.labjs-container.fullscreen .popover {
width: calc(100vw - 2 * var(--padding-internal));
}
/* Repeated for frameless mode on small screens */
@media (max-width: 600px), (max-height: 600px) {
.container.fullscreen .popover {
.labjs-container.fullscreen .popover {
width: 100vw;
}
}
Expand All @@ -490,7 +490,7 @@ table .sticky-top {
margin: 0 auto;
}

.container:not(.fullscreen) .popover {
.labjs-container:not(.fullscreen) .popover {
width: var(--width-container);
}

Expand Down