Add service orders patch #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juliakastrup
approved these changes
Jun 30, 2020
Edely
approved these changes
Jul 1, 2020
| @@ -0,0 +1,6 @@ | |||
| class ServiceOrdersRequest(): | |||
There was a problem hiding this comment.
Essa classe está sendo utilizada na aplicação? Se sim, o método errors é realmente necessário? Aparentemente ele só está chamando o pass.
There was a problem hiding this comment.
Toda a pasta dtos foi feita pela @sarahraqueld , mas não sei onde nem mesmo se é usada. Então queria deixar nas mãos dela a deleção ou não.
| @@ -0,0 +1,13 @@ | |||
| class ServiceOrderRequest(): | |||
There was a problem hiding this comment.
Essa classe é necessária? Aparentemente ela não está sendo utilizada.
juliakastrup
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsáveis: @Adrilene @denisousa @sarahraqueld
Tipo: Feature
issue: #91
Descrição
Implementação da rota PATCH com os testes. Além disso, conserto dos testes anteriores, da ordem de serviço, que estavam com erros.
Schema refatorado com adição de um SchemaBase, com o objetivo de ser útil para as outras collections.
Checklist
Observações
O formato das pastas está diferente do formato da collection de itens.