Feature/adding migrate changing service order #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/v2/migrations/items_from_diagnostico_service_order.py # config/routes.py
…testes e adicionei a correção no loop de acessórios e itens para não efetuar o processo de migração para items já cadastrados.
2 tasks
Edely
approved these changes
Jul 13, 2020
| errors.append({index: message}) | ||
| continue | ||
|
|
||
| erro_schema = ItemSchema().validate(item) |
There was a problem hiding this comment.
Talvez seja uma boa ideia mover as validações de esquema desta classe para validators/validation_request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsáveis: @chicaothiago
Linked Issue: Close #108
Descrição
Foi adicionado à rota de migração a alteração da Ordem de Servicço removendo os campos não mais necessários de acessórios e itens, utilizando id ID de referência nas listas respectivamente.
Checklist
Observações
Foram adicionadas correções nos testes que estavam dando falha. Possivelmente foi causado por mudança no banco de dados.