Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View types #6

Open
KennyGoers opened this issue Mar 21, 2019 · 4 comments
Open

View types #6

KennyGoers opened this issue Mar 21, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@KennyGoers
Copy link

Is there a way to hook into the skeleton view factory? It would be nice to add or exclude view types (for example I have a MPAndroidChat)

@Faltenreich
Copy link
Owner

Good idea! I guess that currently the whole chart is masked and you would like to mask only certain sub-elements of the chart, am I right?

@KennyGoers
Copy link
Author

Actually at the time of showSkeleton() its a ViewGroup with no children so it doesn't show. It comes out better as an entire block. For the time being I just put the Chart in a Framelayout with a View.

@Faltenreich
Copy link
Owner

I understand. You idea of an option to in- or exclude certain Views and ViewGroups makes much sense and I will think of an implementation in the near future. Of course you are free to submit a pull request which I would gladly review if you are in a hurry.

@Faltenreich Faltenreich added the enhancement New feature or request label Jun 20, 2019
@vvictor10
Copy link

@Faltenreich Nice work on the library. Any updates on this issue. I have a loading state screen, where I need to exclude certain views from being masked and show the actual content on them. Would be great to specify a boolean to exclude them from the masking process. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants