-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View types #6
Comments
Good idea! I guess that currently the whole chart is masked and you would like to mask only certain sub-elements of the chart, am I right? |
Actually at the time of showSkeleton() its a ViewGroup with no children so it doesn't show. It comes out better as an entire block. For the time being I just put the Chart in a Framelayout with a View. |
I understand. You idea of an option to in- or exclude certain Views and ViewGroups makes much sense and I will think of an implementation in the near future. Of course you are free to submit a pull request which I would gladly review if you are in a hurry. |
@Faltenreich Nice work on the library. Any updates on this issue. I have a loading state screen, where I need to exclude certain views from being masked and show the actual content on them. Would be great to specify a boolean to exclude them from the masking process. Thanks |
Is there a way to hook into the skeleton view factory? It would be nice to add or exclude view types (for example I have a MPAndroidChat)
The text was updated successfully, but these errors were encountered: