Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Epoxy #15

Open
atonamy opened this issue Jan 21, 2020 · 1 comment
Open

Doesn't work with Epoxy #15

atonamy opened this issue Jan 21, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@atonamy
Copy link

atonamy commented Jan 21, 2020

if I build in EpoxyController my model it doesn't render skeleton

rowItem {
                    id(item.key)
                    onBind { _, view, _ ->
                        val view = view.dataBinding.root
                        val tag = view.tag
                        if(tag == null) {
                            val skeleton = view.createSkeleton()
                            skeleton.showSkeleton()
                            view.tag = skeleton
                        } else if(tag is Skeleton)
                            tag.showSkeleton()
                    }
                }

Could be really nice if this library can support and work with Epoxy

@Faltenreich
Copy link
Owner

Please excuse my late answer! Your issue simply flew under my radar.

I do not have any experience with Epoxy and am currently and in the near future not involved in any project that utilizies this library. Therefor someone like you who effectively uses both Epoxy and SkeletonLayout should be in a better position to fix this issue. Maybe you could do this via a pull request that I will gladly test and then approve.

@Faltenreich Faltenreich added bug Something isn't working help wanted Extra attention is needed labels Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants