Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect output on some submission failures #85

Open
rbx opened this issue Jan 19, 2023 · 2 comments
Open

Incorrect output on some submission failures #85

rbx opened this issue Jan 19, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
1.0

Comments

@rbx
Copy link
Member

rbx commented Jan 19, 2023 •
edited
Loading

When Submit is called multiple times with the same agent group, and any after the first submissions fail, the submission log can contain misleading info such as:

Number of agents (3) for group online is less than requested (1), and no nMin is defined.
@rbx rbx added this to the 0.77 milestone Jan 19, 2023
@rbx rbx added the bug Something isn't working label Jan 19, 2023
@rbx rbx modified the milestones: 0.77, 0.78 Feb 20, 2023
@rbx
Copy link
Member Author

rbx commented Mar 9, 2023 •
edited
Loading

Somewhat related problem: when nMin is given on submit, and submit is called multiple times with a lower number of required agents, then a single submission will be malformed, because for it minAgents > requiredAgents.

@rbx
Copy link
Member Author

rbx commented Mar 9, 2023

Possible solution: submit only once per agent group.

@rbx rbx modified the milestones: 0.78, 0.79 Jun 19, 2023
@rbx rbx modified the milestones: 0.79, 1.0 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@rbx