Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mutex lock of the gRPC requests #38

Open
AndreyLebedev opened this issue Nov 16, 2021 · 0 comments
Open

Improve mutex lock of the gRPC requests #38

AndreyLebedev opened this issue Nov 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@AndreyLebedev
Copy link
Collaborator

CGrpcService class uses std::lock_guard in order to lock the processing of a single request per partition. If request processing hangs then all subsequent requests of the same partition will not be processed.

One can implement a try_lock with a timeout. A request timeout can be used. If the request can't be processed an error must be returned.
@AndreyLebedev AndreyLebedev added the enhancement New feature or request label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreyLebedev