-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display provided mod ids in the printed mod list #894
Comments
provided modids should probably come before nested mods, because nested mods would also need to list their provided modids and it would look weird if the nested provides were put above the nester's. |
DavidCWQ
pushed a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 1, 2024
DavidCWQ
pushed a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 1, 2024
…ial mod dumping method
DavidCWQ
pushed a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 1, 2024
DavidCWQ
added a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 3, 2024
DavidCWQ
added a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 3, 2024
DavidCWQ
added a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 3, 2024
DavidCWQ
added a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 3, 2024
DavidCWQ
added a commit
to DD2480-Group-4/lab4-fabric-loader
that referenced
this issue
Mar 3, 2024
…rresponding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be nice for loader to display mod ids which are provided by loaded mods and what mods are providing them, like nested mods currently work. I would try to implement this but I'm not sure how this should be represented, currently provided mods just inherit the version of the mod that is providing them (as far as I'm aware, I haven't tested that), and just listing the mod id below might be a little unclear to readers. Earlier versions of loader for nested jars said
- org_zeroturnaround_zt-zip 1.14 via optifabric
(example), but doing something verbose like that and prefixing the mod withprovides
doesn't look all that great either.example of proposed behavior
The text was updated successfully, but these errors were encountered: