Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display provided mod ids in the printed mod list #894

Open
tildejustin opened this issue Jan 21, 2024 · 2 comments
Open

display provided mod ids in the printed mod list #894

tildejustin opened this issue Jan 21, 2024 · 2 comments

Comments

@tildejustin
Copy link
Contributor

tildejustin commented Jan 21, 2024

I think it would be nice for loader to display mod ids which are provided by loaded mods and what mods are providing them, like nested mods currently work. I would try to implement this but I'm not sure how this should be represented, currently provided mods just inherit the version of the mod that is providing them (as far as I'm aware, I haven't tested that), and just listing the mod id below might be a little unclear to readers. Earlier versions of loader for nested jars said - org_zeroturnaround_zt-zip 1.14 via optifabric (example), but doing something verbose like that and prefixing the mod with provides doesn't look all that great either.

example of proposed behavior
[17:46:15] [main/INFO]: Loading 22 mods:
    - antigone 2.0.0
    - antiresourcereload 4.0.1
    - atum 1.2.2+1.16.1
    - chunkumulator 1.0.3+MC1.16.1
    - fabricloader 0.15.7
       \-- mixinextras 0.3.5
    - fast_reset 1.4.2
    - forceport 1.2.0
    - java 21
    - krypton 0.1.3-SNAPSHOT+2021-02-20
    - lazydfu 0.1.2
    - lazystronghold 1.1.3
    - lithium 0.6.6
    - minecraft 1.16.1
    - sleepbackground 3.9.1-1.16.x-1.18.1
    - sodiummac 3.0.1+1.16.1
- // not sure if or how this should be qualified
+      \-- sodium
    - speedrunigt 14.1+1.16.1
    - starlight v7
    - state-output 1.1.6+1.16-1.17.1
       \-- state-output-common 1.1.6
    - voyager 1.0.0
    - worldpreview 5.0.0+1.16.1
@tildejustin
Copy link
Contributor Author

provided modids should probably come before nested mods, because nested mods would also need to list their provided modids and it would look weird if the nested provides were put above the nester's.

@tildejustin
Copy link
Contributor Author

image
i also came up with this idea to not confuse with nested mods, but the first one might make more sense if versioned provides are ever introduced

DavidCWQ pushed a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 1, 2024
DavidCWQ pushed a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 1, 2024
DavidCWQ pushed a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 1, 2024
DavidCWQ added a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 3, 2024
DavidCWQ added a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 3, 2024
DavidCWQ added a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 3, 2024
DavidCWQ added a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 3, 2024
DavidCWQ added a commit to DD2480-Group-4/lab4-fabric-loader that referenced this issue Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant