-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoundInstances page #174
Open
JR1811
wants to merge
11
commits into
FabricMC:main
Choose a base branch
from
JR1811:dynamic-sound
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SoundInstances page #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dynamic-sound
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
added
new-content
A new page or set of pages
stage:cleanup
This should be cleaned up
labels
Aug 27, 2024
I this is is well written and should be added |
its-miroma
added
stage:verification
This should be verified
and removed
stage:cleanup
This should be cleaned up
labels
Oct 14, 2024
Just wondering. Has anyone checked this yet? Otherwise, we can just get rid of this page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Issue #70
Content
This page is split into several parts.
The page first explains how to create and use simple SoundInstances and then shows an example of how to make a sound system, which can modulate e.g. its volume and pitch based on the current sound phase and connected BlockEntity values.
Problems & Questions
The current page has not been cleaned up and spellchecked yet. The main reason I'm PRing this now is to ask for opinions.
I was about to delete the 3rd section (starting from the
Advanced SoundInstances
header) because of the scope of this topic. But it shows how abstract systems can be created. I'm pretty sure this "huge" in-depth example does not belong in the Fabric Docs, but I wanted to hear other opinions before I scrap all of that again.The Choices before I move into the clean-up phase:
This page uses but does not cover BlockEntities and custom S2C networking. Those should be handled on separate pages.