Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-server communication is insecure #22

Open
jonnor opened this issue Feb 28, 2016 · 1 comment
Open

Client-server communication is insecure #22

jonnor opened this issue Feb 28, 2016 · 1 comment

Comments

@jonnor
Copy link
Contributor

jonnor commented Feb 28, 2016

The server will happily execute arbitrary commands sent by the client. Just type in rm -rf foo and it will be ran.

There is some 'mitigration' in that the Websocket server will only accept connections from the same IP address. However, it is impossible to safely expose fabmodules over a network, which is one of the major benefits of a web-based system.

Proposed is to only execute a known subset of commands (enforced by server), not arbitrary stuff.

@fibasile
Copy link
Contributor

fibasile commented Mar 3, 2016

This is true, I think limiting access to a specific set of commands (in the same folder as mod_server) would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants