Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rOpenSci review: Unit tests for HTTP requests #68

Open
ahasverus opened this issue Oct 14, 2024 · 0 comments
Open

rOpenSci review: Unit tests for HTTP requests #68

ahasverus opened this issue Oct 14, 2024 · 0 comments
Assignees
@ahasverus
Labels
code review rOpenSci review

Comments

@ahasverus
Copy link
Member

Editor comment (5)

About testing the download functions: I looked up the tests for the download function but I'm not sure if it follows the best practices. I need some time to read more about testing functions that access resources on the web (eg. the dev guide recommends the book HTTP testing in R). As you wrote in the submission, "some functions are difficult to test (HTTP requests)". I'll be back with that feedback soon!
@ahasverus ahasverus added the code review rOpenSci review label Oct 14, 2024
@ahasverus ahasverus self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahasverus ahasverus

Labels
code review rOpenSci review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahasverus