Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run QAQC tools for runs in two databases #49

Open
cbedwards-dfw opened this issue Dec 10, 2024 · 2 comments
Open

Add ability to run QAQC tools for runs in two databases #49

cbedwards-dfw opened this issue Dec 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cbedwards-dfw
Copy link
Contributor

Brought up by Jason in the software meeting. This seems like it could really streamline some of our NOF processes.

@cbedwards-dfw cbedwards-dfw added the enhancement New feature or request label Dec 10, 2024
@cbedwards-dfw
Copy link
Contributor Author

Not sure if it makes sense to add flexibility to compare_inputs() (and similar functions), or to have two separate versions of each function (one for a single db input, one for two). If we have two versions of each function, I would suggest two wrapper functions that then each call the same backend function that does all the serious work.

@Ty-WDFW
Copy link
Contributor

Ty-WDFW commented Dec 12, 2024

Yeah on board with the switching but in the opposite direction... Maybe make compare_runs() detect an argument for a second database and switch between functions depending on whether it's present or not?

Something like:

fram_db1 <- connect_fram_db(path1)
fram_db2 <- connect_fram_db(path2)

fram_db1 |>
    compare_runs(second_db = fram_db2, run_ids = c(21,12)) 

With compare_runs() looking like

compare_runs <- function(fram_db, second_db, run_ids, tolerance = .01){
if(is.null(second_db)){
 #compare_runs_for_one_db
} else {
 #compare_runs_for_two_db
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants