Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment directed graph visualiser support #138

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Environment directed graph visualiser support #138

merged 2 commits into from
Oct 23, 2024

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Oct 19, 2024

@Robadob Robadob requested a review from ptheywood October 19, 2024 17:32
@Robadob Robadob self-assigned this Oct 19, 2024
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, and works on linux.

We could prolly just ignore the linting failures for now and address them sepearately.
In this repo, I'd say we suppress/ignore the indent within a namespace warnings, but include what you use warnings might be worth addressing.

Probably better to fix in the main repo first though so we have consistent linting supressions across the repos.

Some inconsistency between DynamicLine and DynamicLines maybe? (Or I'm just not looking closely enough).

Will approve for now, but don't merge till review on the related PR is sorted incase of changes.

@Robadob
Copy link
Member Author

Robadob commented Oct 23, 2024

Some inconsistency between DynamicLine and DynamicLines maybe? (Or I'm just not looking closely enough).

The latter, the lock protected the storage of all dynamic lines from race conditions, whereas update updates a specific dynamic line.

@Robadob Robadob merged commit dab83d0 into master Oct 23, 2024
12 of 14 checks passed
@Robadob Robadob deleted the graph_vis branch October 23, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants