Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImGUI headers are public #111

Open
Robadob opened this issue Dec 1, 2022 · 0 comments
Open

ImGUI headers are public #111

Robadob opened this issue Dec 1, 2022 · 0 comments

Comments

@Robadob
Copy link
Member

Robadob commented Dec 1, 2022

This file needs tweaking to move dependent components into .cpp. I think it should be doable, just a minor change.

FLAMEGPU2-visualiser/include/flamegpu/visualiser/config/ImGuiWidgets.h

Line 24 in 3c4d209

template <> struct imgui_type<char> { static constexpr ImGuiDataType_ t = ImGuiDataType_S8; static constexpr const char* fmt = "%c"; };

Then inside src/CMakeLists.txt ImGui can be changed to private (look for "# imgui must be public as the headers are visible in flamegpu/FLAMEGPU2").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Robadob