Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconverter does not correctly pick up --generate template flag #208

Closed
lukaspie opened this issue Jan 17, 2024 · 2 comments · Fixed by #209
Closed

dataconverter does not correctly pick up --generate template flag #208

lukaspie opened this issue Jan 17, 2024 · 2 comments · Fixed by #209

Comments

@lukaspie
Copy link
Collaborator

The --generate-template flag of pynxtools/dataconverter seems to not be working for me at the moment. If I pass that flag, the template is not printed to the console.

Probably comes from changes to the logger in #191. This seems to be related to the setting of the logger level, see here.

Quick fix: Change to logger.error(template) in

logger.info(template)

We should check that all other flags (like --fair, --undocumented) are still picked up correctly.

@domna @sherjeelshabih @RubelMozumder

@lukaspie lukaspie linked a pull request Jan 17, 2024 that will close this issue
@sherjeelshabih
Copy link
Collaborator

I had a quick look. It seems some other code is setting the logging level back to warning.

@lukaspie
Copy link
Collaborator Author

See the linked PR, there's some explanation why this might happen. I am not an expert on logging though, so would be nice if you could have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants