Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add igor support #2

Open
domna opened this issue Feb 20, 2024 · 4 comments · May be fixed by #7
Open

Add igor support #2

domna opened this issue Feb 20, 2024 · 4 comments · May be fixed by #7
Assignees

Comments

@domna
Copy link
Collaborator

domna commented Feb 20, 2024

The reader should also support igor binarywave files

@lukaspie
Copy link
Contributor

lukaspie commented Feb 22, 2024

Hey @domna, I just received some XPS files from a user that are also igor binarywave files. Maybe we could also provide a generic igor parser within FAIRmat-NFDI/pynxtools#250 which could be specialized by the plugins?

@domna
Copy link
Collaborator Author

domna commented Feb 22, 2024

Yes, we could just add a standard parsing function for igor files as we will do with json and yaml files. I don't know generally how uniform the data is stored in the format but I think we will be able to figure something out.

@rettigl
Copy link
Collaborator

rettigl commented Feb 22, 2024

Well, igor waves contain matrix data up to 4 dimensions, with attached unit scaling to each dimension (start, step, unit). Additionally, there is a wavenote, which can contain text.
Typically, the wave note is being used to store metadata, but the format of this is undefined (often key=value\r\n format).

@domna
Copy link
Collaborator Author

domna commented Feb 22, 2024

Well, igor waves contain matrix data up to 4 dimensions, with attached unit scaling to each dimension (start, step, unit). Additionally, there is a wavenote, which can contain text. Typically, the wave note is being used to store metadata, but the format of this is undefined (often key=value\r\n format).

Ok, but then we could add general support for the matrix data and custom support for reading data from the note or try key/value notation by default. I will draft something in the multi format reader and then we can see whether this works for us.

@lukaspie lukaspie linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants