Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new XRD reader #18

Open
aalbino2 opened this issue Nov 20, 2023 · 7 comments
Open

new XRD reader #18

aalbino2 opened this issue Nov 20, 2023 · 7 comments

Comments

@aalbino2
Copy link
Contributor

I would like to have implemented a new reader.

These two kinds of file are about a 2theta-2theta and rocking-curve measurement.

Ga2O3_013_B_2theta-theta-wide-Thermo.txt
Ga2O3_013_B_Rocking004_Thermo.txt

@ka-sarthak
Copy link
Collaborator

@aalbino2 @budschi @hampusnasstrom
how are we proceeding on this? Given that the readers are to be moved into pynxtools.

@aalbino2
Copy link
Contributor Author

I would talk about that in the next Area B TF metting, @sanbrock @budschi ?

@aalbino2
Copy link
Contributor Author

@Pepe-Marquez @hampusnasstrom @sherjeelshabih did you have chance to discuss this reader moving already? If not, let's try to make the point on that.
I hope next TF Area B is a spot that fits everyone

@aalbino2
Copy link
Contributor Author

Forgot to tag @RubelMozumder, also involved in this

@RubelMozumder
Copy link
Contributor

@aalbino2, we can extend the file parsers once a common workflow is part of the main pipeline of xrd measurement.

@aalbino2
Copy link
Contributor Author

I will talk to @sherjeelshabih next Thursday about that. If we do not experience any slowing down of our developments, installation, and use with inclusion of mandatory requirement of pynxtools within the nomad-measurement plugin, it can be ok for us to go for that.

@aalbino2
Copy link
Contributor Author

aalbino2 commented May 27, 2024

Thanks everyone for today's discussion.

I summarize here what we agreed on and what we still miss to close the MR #92

We will place the reader code in a new separate repo that will not have dependencies neither on nomad nor on pynxtools-xrd. This repo will be imported in nomad-measurements and in pynxtools to be able to parse XRD files.

In this way Area A & B can contribute together to extend the parser of XRD files in this new repo.

The existing repo https://github.com/FAIRmat-NFDI/pynxtools-xrd contains the mapping between the dictionary produced by the XRD reader and the dictionary that will be streamed in the nexus pipeline.

Area A will make use of the dictionary produced by the reader directly, Area B will map this into the nexus dictionary, as Sherjeel already implemented.

What we agreed on is to avoid inter-dependencies between tools so we can pick them and make use and develop them efficiently.

TODOs:

I think that's it. We need to test the plugin and the nexus converter after everything will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants