Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend parser template to create an ELN-ready entry from a file #41

Open
fabianschoeppach opened this issue Dec 4, 2024 · 5 comments
Open

Comments

@fabianschoeppach
Copy link
Contributor

Hey,

as we have already discussed last week, there is an urgent need for a template (or think of it as a best practice guide) on how to write an ELN-ready entry from a measurement file (e.g. a simple two-column csv file with possibly a header with metadata).
I think employing this in this plugin template would go long way.

I think reading from files into ELN entries is THE thing in the experimental area of how data gets into Nomad, and unfortunately the current parser template does not help with that at all.

@fabianschoeppach
Copy link
Contributor Author

Steps I can think of right now:

  • provide an example measurement file
  • write a parser that only creates an empty entry with the linked file
  • write a minimal schema with filereader in normalize().
  • use official versions of helper functions like create_archive() if they are available.

@blueraft
Copy link
Collaborator

blueraft commented Dec 4, 2024

In my (admittedly lay) view, instead of having this be part of the template, this sounds more like something that we should provide more examples of - similar to what's done here. If area C is writing a parser, this measurements stuff is probably not very helpful then. What do you think @lauri-codes?

@fabianschoeppach
Copy link
Contributor Author

Hey, thanks for the feedback!

I agree the current parser template is slanted toward simulation data and doesn’t address the needs of experimental workflows, which basically always require ELN capabilities for their entries. While I don’t know the balance of users working with simulation vs. experimental data, in my opinion experimentalists need better support. Right now, the parser template is rather useless for them.

Maybe it would be good to split the parser template into two types: Simulation Parser/no ELN-mode/as is and Experimental Parser/ELN-mode. This would better cater to both groups and make the templates more useful across the board. Thoughts?

@blueraft
Copy link
Collaborator

blueraft commented Dec 4, 2024

I agree that we should cater to experimentalists better here, just not sure if a more complicated template is the way to go here. The goal of the template was to have a very minimal package.

@hampusnasstrom and I discussed having more examples for different kind of plugins, which show cases plugin functionality at different difficulty levels. We could then have examples there for multiple categories of plugins (simulation/ experimental/ etc). It'd also be easier to maintain all of the examples in a separate repo.

@hampusnasstrom
Copy link
Contributor

I'm not sure what you want to have in the template @fabianschoeppach? I think I agree with @blueraft that we should provide more examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants