Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

Trying to integrate flash #16

Open
subhafalcon opened this issue Jan 29, 2019 · 0 comments
Open

Trying to integrate flash #16

subhafalcon opened this issue Jan 29, 2019 · 0 comments

Comments

@subhafalcon
Copy link

I am trying to integrate flash (user selects to capture an image with the flash on or off). I have noticed if the flash is run, and after the image is captured with the flash (it has run a pre-capture as well) the preview becomes dim after the flash. I am wondering if the line
1052 in Camera2Source.java:

mCaptureSession.setRepeatingRequest(mPreviewRequest, mCaptureCallback, mBackgroundHandler);

Should be
mCaptureSession.setRepeatingRequest(mPreviewRequestBuilder.build(), mCaptureCallback, mBackgroundHandler);

As mPreviewRequest only gets set once on createCameraPreview.

Camera2Basic also has the mPreviewRequest passing in, so I wanted to verify why this has to the previewrequest set on start up and not the updated one. I using Pixel3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant