Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optionally require JWT token to access api, logs requests #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: optionally require JWT token to access api, logs requests #39

wants to merge 2 commits into from

Conversation

VolcanoCookies
Copy link
Contributor

If JWT_SECRET env param is specified, all routes will require a JWT token to access.
Any requests made will be logged in a JSON format for AWS cloudwatch.

@VolcanoCookies VolcanoCookies requested a review from birme June 26, 2023 01:02
@VolcanoCookies VolcanoCookies self-assigned this Jun 26, 2023
@VolcanoCookies VolcanoCookies linked an issue Jun 26, 2023 that may be closed by this pull request
Optional support for protecting endpoint with JWT token and logging #37
Open
@VolcanoCookies VolcanoCookies added the enhancement New feature or request label Jun 26, 2023
birme
birme requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks as the heartbeat endpoint also requires token when enabled. In that case that needs to change and should be excluded from the token requirement

@birme
Copy link
Contributor

birme commented Sep 29, 2023

I'm thinking, is there a way the actual length of the token can be reduced. I am worried about limitations in URL length

@birme birme force-pushed the feat/optional-support-jwt branch from 07efb6b to ef90e02 Compare September 29, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme requested changes

Assignees

@VolcanoCookies VolcanoCookies

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional support for protecting endpoint with JWT token and logging
2 participants
@VolcanoCookies @birme