Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule missing from the release #329

Open
yarda opened this issue Jun 15, 2021 · 4 comments
Open

Submodule missing from the release #329

yarda opened this issue Jun 15, 2021 · 4 comments

Comments

@yarda
Copy link
Contributor

yarda commented Jun 15, 2021

....
Make Error at CMakeLists.txt:11 (message):
  CMake/common missing, run: git submodule update --init

I tried both the zip and tar.gz files from the release (lunchbox-1.17.0) and the submodule is not there. I think the release should be complete including the submodules, otherwise it complicates the downstream distro packaging (I am trying to get the package into Fedora).

@yarda
Copy link
Contributor Author

yarda commented Jun 15, 2021

The same for Servus.

@yarda
Copy link
Contributor Author

yarda commented Jun 15, 2021

The same for Servus.

I think it should allow building with the system Servus.

@yarda
Copy link
Contributor Author

yarda commented Jun 15, 2021

The same for Servus.

I think it should allow building with the system Servus.

Please ignore the comment about Servus, it seems it builds with system Servus OK.

@yarda
Copy link
Contributor Author

yarda commented Jun 16, 2021

FYI Fedora review ticket:
https://bugzilla.redhat.com/show_bug.cgi?id=976793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant