[$250] Workspace subscription - Expensify whisper message contains USD instead of GBP

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found while executing QA for PR #54340

Version Number: v9.0.81-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54340
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacOS Catalina 10.15.7
App Component: Workspace Settings

Action Performed:

Precondition: use VPN to locate yourself in UK.

1. Login with a new public domain user.
2. Finish onboarding.
3. Create workspace
   4, Go to Settings > Workspace
4. More features > turn ON Accounting
5. Go to Accounting > Connect NetSuit
6. Upgrade workspace
7. Go to #admins room

Expected Result:

Whisper message contains GBP currency.

Actual Result:

Whisper message contains USD currency.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876714113440426836
• Upwork Job ID: 1876714113440426836
• Last Price Increase: 2025-01-07

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Tony-MK]

The whisper message comes from api/UpgradeToCorporate? so this needs to be fixed internally.

We also need to fix GenericFeaturesView because it uses workspace.upgrade.commonFeatures.benefits.note which has a static price and the user's local currency will not be displayed.

App/src/languages/en.ts

Line 4385 in cd43345

note: 'The Control plan starts at $9 per active member per month.',

App/src/pages/workspace/upgrade/GenericFeaturesView.tsx

Line 54 in cd43345

{translate('workspace.upgrade.commonFeatures.benefits.note')}{' '}

Let's follow up on this with PR.

What do you think?

cc: @ahmedGaber93 @amyevans

[amyevans]

Sounds good. @Tony-MK I'll assign you to work on the frontend portion.

The whisper message comes from api/UpgradeToCorporate? so this needs to be fixed internally.

I can handle this part. For what it's worth there is already some logic in that API command to account for the user's currency, but it is only relying on the billing card's currency, if present, before falling back to USD. I will update it to match the frontend logic of:

App/src/hooks/usePreferredCurrency.ts

Lines 9 to 16 in cd43345

	/**
	* Get user's preferred currency in the following order:
	*
	* 1. Payment card currency
	* 2. User's local currency (if it's a valid payment card currency)
	* 3. USD (default currency)
	*
	*/

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876714113440426836

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Tony-MK]

The PR is ready for review.