Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank account - Workspace currency is not changed to USD after clicking Update to USD #54691

Closed
4 of 8 tasks
mitarachim opened this issue Dec 31, 2024 · 10 comments
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace default currency is not USD.
  1. Go to staging.new.expensify.com
  2. Go to Workspace settings > Workflows.
  3. Click Connect bank account.
  4. Click Update to USD.
  5. Go to Workspace profile.

Expected Result:

Workspace currency will be changed to USD after clicking Update to USD

Actual Result:

Workspace currency is not changed to USD after clicking Update to USD

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704687_1735685150019.20250101_064254.mp4

View all open jobs on GitHub

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 31, 2024
Copy link

melvin-bot bot commented Dec 31, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 31, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 31, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 31, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@linhvovan29546
Copy link
Contributor

Offending PR: #52812

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jan 1, 2025

Thanks @linhvovan29546 ! I'm unable to reproduce on my [email protected] account, after I click Connect bank account in workflow I'm stuck on

We’re taking a look at your information. You'll be able to continue with next steps shortly.

With it being NYE here and New Year's Day tomorrow, I don't imagine we'll be deploying to production for a bit.

@mallenexpensify
Copy link
Contributor

@pasyukevich 👀 please as #52812 might be the offending PR

@linhvovan29546
Copy link
Contributor

linhvovan29546 commented Jan 1, 2025

With it being NYE here and New Year's Day tomorrow, I don't imagine we'll be deploying to production for a bit.

I looked into the details, and it fails in other places as well. That PR only update in the WorkspaceProfileCurrencyPage and not update other places
image

eg: #54696 (comment)

@pasyukevich
Copy link
Contributor

Not reproducible after fix pr - #54722

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

Closing as completed, I can't reproduce on staging

@grgia grgia closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants