Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb/Chrome - Expenses - The Save button on the Merchant page is unresponsive in offline mode #54671

Closed
1 of 8 tasks
lanitochka17 opened this issue Dec 30, 2024 · 10 comments
Closed
1 of 8 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.79-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5389852
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

New user has created a new workspace by selecting "Manage my team expenses" and has started their onboarding checklist.

  1. Go offline by disabling the internet connection in the device settings (not from the Troubleshot page)
  2. Go to the workspace chat automatically created
  3. Tap on + button > Create expense
  4. Enter any amount
  5. Enter a merchant
  6. On the Merchant page, tap the Save button

Expected Result:

The Save button leads to the Confirm details page and the merchant is displayed in the Merchant field

Actual Result:

The Save button on the Merchant page is unresponsive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6704348_1735591676288.Save_button_unresponsive.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 30, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 30, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@blimpich
Copy link
Contributor

Fairly minor. Not sure if this should be considered a blocker. I'll look into it though, there a few suspicious PRs that might make this an easy fix.

@blimpich
Copy link
Contributor

Working on this. Doesn't repo in web, issue says it only repos in Android mweb. Currently having trouble getting my local Android mweb up and running.

@blimpich
Copy link
Contributor

Alright I finally got mweb working, reproduces on main. Testing suspicious PRs to see if reverting them fixes the issue.

@blimpich
Copy link
Contributor

Confirmed it is this PR: #53529. Reverting it fixed the issue. Going to revert.

@huult
Copy link
Contributor

huult commented Dec 31, 2024

PR fixed this issue already to merge

@huult
Copy link
Contributor

huult commented Dec 31, 2024

@blimpich herể is the pull request #54634

@blimpich
Copy link
Contributor

Ah I see. Looks like this issue is basically a dupe. Since I don't consider this super high priority and we already have a fix on the way I'm just going to remove the deploy blocker and mark this as a dupe of #54609

@blimpich blimpich removed the DeployBlockerCash This issue or pull request should block deployment label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants