[$250] After paying only a portion of the expense, user not scroll down to new expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Create 2 expenses
2. Hold 1 expense
3. Click pay elsewhere button
4. Choose Pay only

Expected Result:

The user scrolls down to new expense.

Actual Result:

The user does not scroll down to new expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bug.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021874051725449499647
• Upwork Job ID: 1874051725449499647
• Last Price Increase: 2024-12-31
• Automatic offers:
• FitseTLT | Contributor | 105583454

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying only a portion of the expense, user not scroll down to new expense.

What is the root cause of that problem?

We are not calling Report.notifyNewAction to scroll down when call API PayMoneyRequest

App/src/libs/actions/IOU.ts

Lines 7924 to 7926 in 12e0941

	playSound(SOUNDS.SUCCESS);
	API.write(apiCommand, params, {optimisticData, successData, failureData});
	}

What changes do you think we should make in order to solve the problem?

1. Add function Report.notifyNewAction here

    Report.notifyNewAction(chatReport.reportID, userAccountID);

App/src/libs/actions/IOU.ts

Lines 7924 to 7926 in 12e0941

	playSound(SOUNDS.SUCCESS);
	API.write(apiCommand, params, {optimisticData, successData, failureData});
	}

2. We also need to update lastVisibleActionCreated of chatReport to make sure that hasNewestReportAction here is true

     lastVisibleActionCreated: optimisticExpenseReportPreview.created,

App/src/libs/actions/IOU.ts

Lines 6730 to 6736 in 12e0941

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`,
	value: {
	iouReportID: optimisticExpenseReport.reportID,
	},
	},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-30 14:04:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying only a portion of the expense, user not scroll down to new expense

What is the root cause of that problem?

We already notify new action on pay request here

App/src/libs/actions/IOU.ts

Line 7936 in 12bbe02

Report.notifyNewAction(iouReport?.reportID ?? '', userAccountID);

but it always notify new action on iou report so when we pay from report preview we are on chat report (not iou report) so it won't work properly and we also missed to update lastVisibleActionCreated on the chat report with the new preview action created from partial hold here

App/src/libs/actions/IOU.ts

Lines 6730 to 6736 in 12e0941

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`,
	value: {
	iouReportID: optimisticExpenseReport.reportID,
	},
	},

What changes do you think we should make in order to solve the problem?

We need to know from where the pay request is called we can easily find it by getTopmostReportID or we can pass it as a param (which would be the chat report when paid from the report preview case or the iou Report when paid from money report header case) and then notifyNewAction for that param instead of always notifying for iouReport

App/src/libs/actions/IOU.ts

Line 7936 in 12bbe02

Report.notifyNewAction(iouReport?.reportID ?? '', userAccountID);

    Report.notifyNewAction(Navigation.getTopmostReportId() ?? iouReport?.reportID ?? '', userAccountID);

and update lastVisibleActionCreated accordingly here

App/src/libs/actions/IOU.ts

Lines 6740 to 6741 in 12bbe02

	value: {
	iouReportID: optimisticExpenseReport.reportID,

                lastVisibleActionCreated: optimisticExpenseReportPreview.created,

We have similar problems with approve and other money request flows too so we should fix it similarly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We will mock getTopmostReportID to return the chat report id and then we will assert that the notifyNewAction is called with the chat report id not the iou report.

What alternative solutions did you explore? (Optional)

We can also avoid notifying new action if the pay is from report preview and the payment is full because there is no new action to notify on the chat report

const topReportID = Navigation.getTopmostReportId();
    if (!(topReportID === chatReport.reportID && full)) {
        Report.notifyNewAction(topReportID ?? iouReport?.reportID ?? '', userAccountID);
    }

[dukenv0307]

@MitchExpensify I can help take it as C+ since I had the prior context on this. Thanks

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021874051725449499647

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[dukenv0307]

@FitseTLT Your proposal looks promising. Can you add the automated tests to cover this case? We also need to fix the approve flow.

[dukenv0307]

friendly bump @FitseTLT

[FitseTLT]

@dukenv0307 Updated

[dukenv0307]

Thanks @FitseTLT, let's go with @FitseTLT's proposal. We can discuss the test section in detail during PR phase.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Works for me!

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@FitseTLT any updates?

[FitseTLT]

Will create PR tomorrow

[dukenv0307]

@FitseTLT bump