Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-seed memoized keychain #80

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: multi-seed memoized keychain #80

wants to merge 7 commits into from

Conversation

mvayngrib
Copy link
Collaborator

@mvayngrib mvayngrib commented Apr 2, 2024 •
edited
Loading

depends on #78
closes #79

don't review yet (but review commit by commit when it's ready)

Test Plan

apply diff to add private devDeps needed for integration test

diff --git a/features/keychain/package.json b/features/keychain/package.json
index d3be8fa..f35ab2b 100644
--- a/features/keychain/package.json
+++ b/features/keychain/package.json
@@ -25,7 +25,7 @@
     "lint": "eslint . --ignore-path ../../.gitignore",
     "lint:fix": "yarn lint --fix",
     "test": "jest",
-    "todo:reenable:test:integration": "jest --testMatch='**/*.integration-test.js'"
+    "test:integration": "jest --testMatch='**/*.integration-test.js'"
   },
   "dependencies": {
     "@exodus/basic-utils": "^2.0.0",
@@ -43,7 +43,14 @@
     "minimalistic-assert": "^1.0.1"
   },
   "devDependencies": {
+    "@exodus/argo": "latest",
+    "@exodus/assets": "latest",
+    "@exodus/cardano-lib": "^2.0.3",
+    "@exodus/ethereum-lib": "^3.3.6",
     "@exodus/key-ids": "^1.0.0",
+    "@exodus/solana-lib": "^1.3.11",
+    "@exodus/solana-meta": "^1.0.2",
+    "@exodus/storage-memory": "^2.1.1",
     "bip39": "2.6.0",
     "eslint": "^8.44.0",
     "events": "^3.3.0",
  • yarn test:integration should pass

@mvayngrib mvayngrib self-assigned this Apr 2, 2024
mvayngrib
mvayngrib commented Apr 2, 2024
View reviewed changes
features/keychain/module/__tests__/memoized-keychain.test.js
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapted from the one removed here 82e5cf2

@mvayngrib mvayngrib force-pushed the mv/memoized-multi-seed branch from b110b32 to 5c3bf16 Compare April 2, 2024 14:12
@mvayngrib mvayngrib mentioned this pull request Apr 2, 2024
Open
@andrejborstnik andrejborstnik force-pushed the andrej/lock-for-private-keys branch from 1de6179 to 58412d5 Compare April 4, 2024 06:54
@andrejborstnik andrejborstnik force-pushed the andrej/lock-for-private-keys branch from a1d8283 to 12bb541 Compare April 8, 2024 12:29
Base automatically changed from andrej/lock-for-private-keys to master April 8, 2024 13:13
@mvayngrib mvayngrib force-pushed the mv/memoized-multi-seed branch from d62489d to 9724ba1 Compare April 10, 2024 17:03
@github-actions GitHub Actions
Copy link

Houston, this is Conflict Bot. We have a conflict. I repeat, we have a conflict. @mvayngrib please rebase. Acknowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewde kewde Awaiting requested review from kewde kewde will be requested when the pull request is marked ready for review kewde is a code owner

@diegomura diegomura Awaiting requested review from diegomura diegomura will be requested when the pull request is marked ready for review diegomura is a code owner

@sparten11740 sparten11740 Awaiting requested review from sparten11740 sparten11740 will be requested when the pull request is marked ready for review sparten11740 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mvayngrib mvayngrib

Labels
blocked/needs-rebase feature keychain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor memoized-keychain to support multi-seed
1 participant
@mvayngrib