Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: replace custom FindMSGFMT.cmake by FindGettext #536

Closed
piponazo opened this issue Nov 9, 2018 · 0 comments · Fixed by #538
Closed

CMake: replace custom FindMSGFMT.cmake by FindGettext #536

piponazo opened this issue Nov 9, 2018 · 0 comments · Fixed by #538
Labels
CMake Configuration issues related with CMake
Milestone
old-master

Comments

@piponazo
Copy link
Collaborator

piponazo commented Nov 9, 2018

This is related with #527.

It seems that at some point the file FindMSGFMT.cmake was introduced to deal with the .PO localisation files. Now CMake provides FindGettext which seems to be doing the same.

We should always try to use the module provides by CMake since they are maintained by the community.
@piponazo piponazo added good first issue CMake Configuration issues related with CMake labels Nov 9, 2018
@piponazo piponazo added this to the v0.28 milestone Nov 9, 2018
This was referenced Nov 12, 2018
Closed
Merged
piponazo added a commit that referenced this issue Nov 13, 2018
@piponazo
resolve #536
b91c0a8
piponazo added a commit that referenced this issue Nov 13, 2018
@piponazo
Automatic update of .po files after resolving #536
fecf313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CMake Configuration issues related with CMake
Projects
None yet
Milestone
old-master
Development

Successfully merging a pull request may close this issue.

Updates about translations system
1 participant
@piponazo