ICC test bug on Fedora 41.

[neheb]

Describe the bug

[ERROR] The output of the testcase mismatch the reference
[INFO] The output has been saved to file /home/mangix/devstuff/exiv2/test/tmp/icc-test.out
[INFO] simply_diff:
/home/mangix/devstuff/exiv2/test/data/test_reference_files/icc-test.out: 762 lines
/home/mangix/devstuff/exiv2/test/tmp/icc-test.out: 762 lines
The first mismatch is in line 313:
<     9144 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9144 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa

Desktop (please complete the following information):

• OS and version: Fedora 40
• Exiv2 version and source: main
• Compiler and version: GCC 14.2.1 and clang++ 18.1.8
• Compilation mode and/or compiler flags: cmake .. -G Ninja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DEXIV2_BUILD_SAMPLES=TRUE -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_CURL=ON -DEXIV2_ENABLE_VIDEO=ON -DEXIV2_BUILD_SAMPLES=ON -DEXIV2_BUILD_UNIT_TESTS=ON

Additional context

I've been trying with multiple compiler flags. It's all the same. Something tells me my git checkout is cursed...

edit: oh it's all messed up:

313,325c313,325
<     9144 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9144 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa
332,344c332,344
<     9101 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9101 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa
350,362c350,362
<     9101 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9101 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa
369,381c369,381
<     9144 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9144 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa
388,400c388,400
<     9101 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9101 | iCCP  | 1152626 | ICC profile..x...eP.[[email protected]... | 0xb9a37efa
406,418c406,418
<     9101 | iCCP  |     293 | ICC profile..x.c``2ptqre.``..+ | 0x7d41600b
>     9101 | iCCP  |     300 | ICC [email protected] | 0x22dc201e
425,437c425,437
<     9144 | iCCP  |     293 | ICC profile..x.c``2ptqre.``..+ | 0x7d41600b
>     9144 | iCCP  |     300 | ICC [email protected] | 0x22dc201e
444,456c444,456
<     9101 | iCCP  |     293 | ICC profile..x.c``2ptqre.``..+ | 0x7d41600b
>     9101 | iCCP  |     300 | ICC [email protected] | 0x22dc201e

This looks like a zlib issue based on my reading of the code. ping @kevinbackhouse

[neheb]

Aha.

I think the actual bug is that fedora does not provide classical zlib but zlib-ng.

[neheb]

I tried fixing it with compress2 instead of compress. at 5:

<     9144 | iCCP  | 1159185 | ICC profile..x...uP.[[email protected] | 0xd3dbe519
>     9144 | iCCP  | 1160118 | ICC profile..x^..eP.K........" | 0x08517905

and 6 is the same as here.

edit2: nope. all compression levels differ in size.

I wonder if exiv2 should switch to libdeflate instead.

edit3: looks like same problem there.