Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanonRFLensType values are wrong in canonmn_int.cpp #2059

Closed
EC1000 opened this issue Jan 23, 2022 · 4 comments · Fixed by #2087
Closed

CanonRFLensType values are wrong in canonmn_int.cpp #2059

EC1000 opened this issue Jan 23, 2022 · 4 comments · Fixed by #2087
Labels
bug lens Issue related to lens detection

Comments

@EC1000
Copy link

EC1000 commented Jan 23, 2022

Describe the bug

canonRFLensType values are wrong in https://github.com/Exiv2/exiv2/blob/main/src/canonmn_int.cpp#L2462-L2482 (257 for all Canon RF lenses, while it should be a different number for each lens except Canon RF 50mm F1.2L USM).

Expected behavior

The correct values are described here: https://exiftool.org/TagNames/Canon.html (search "RFLensType").

@EC1000 EC1000 added the bug label Jan 23, 2022
@postscript-dev
Copy link
Collaborator

@EC1000: Unlike ExifTool, Exiv2 usually adds a test image to demonstrate each of the different lenses containing that description. The Exif.CanonFi.RFLensType values in your post were added in #1451, but for some reason didn't include test images. @alexvanderberkel where did the lens information come from?

@alexvanderberkel
Copy link
Member

@postscript-dev I did notice the issue as well and started to work on correcting the issue ##1628. However, I didn't find the time to complete the pull request with test images etc. so far.

@postscript-dev
Copy link
Collaborator

@alexvanderberkel: No problem. As you have experience with Canon cameras, are you free to deal with this current issue?

@alexvanderberkel
Copy link
Member

I would like to finish that pull request. It should fix the issue in version 1.0, though I'm still a bit limited timewise...

@hassec hassec added the lens Issue related to lens detection label Jan 23, 2022
@clanmills clanmills linked a pull request Feb 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lens Issue related to lens detection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants