fix #1459: диагностика использования встроенной функции как процедуры

[Mr-Rm]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling for built-in functions in the parser, providing clearer feedback when they are incorrectly used as procedures.

[coderabbitai]

Walkthrough

The changes involve enhancements to the DefaultBslParser class within the src/OneScript.Language/SyntaxAnalysis/DefaultBslParser.cs file. Specifically, the BuildComplexStructureStatement method has been modified to improve error handling by adding a conditional check for built-in functions. This new check allows for more precise error reporting when such functions are mistakenly used as procedures, refining the control flow without altering the overall structure of the method.

Changes

File Path	Change Summary
src/OneScript.Language/SyntaxAnalysis/DefaultBslParser.cs	Enhanced error handling in BuildComplexStructureStatement method with a new check for built-in functions.

Poem

In the land of code where bunnies play,
A parser danced in a bright new way.
With checks for functions, oh what a sight,
Errors now clearer, shining so bright!
Hops of joy in the syntax field,
Better feedback is our new shield! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/OneScript.Language/SyntaxAnalysis/DefaultBslParser.cs (1)

714-722: Improved error handling for built-in functions used as procedures.

The added code block enhances error detection by checking if a built-in function is being used as a procedure. This change directly addresses the PR objective of diagnosing the use of built-in functions as procedures.

Some suggestions for improvement:

1. Consider extracting the error message to a constant or resource file for easier maintenance and potential localization.
2. The else block could be simplified by removing the unnecessary variable assignment.

Consider applying these changes:

 if (LanguageDef.IsBuiltInFunction(_lastExtractedLexem.Token))
 {
-    AddError(LocalizedErrors.UseBuiltInFunctionAsProcedure());
+    AddError(LocalizedErrors.UseBuiltInFunctionAsProcedure(_lastExtractedLexem.Content));
 }
 else
 {
-    var expected = _tokenStack.Peek();
-    AddError(LocalizedErrors.TokenExpected(expected));
+    AddError(LocalizedErrors.TokenExpected(_tokenStack.Peek()));
 }

This change assumes that LocalizedErrors.UseBuiltInFunctionAsProcedure() can accept a parameter for the function name, which would make the error message more specific and helpful.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 44709af and 047423a.

📒 Files selected for processing (1)

• src/OneScript.Language/SyntaxAnalysis/DefaultBslParser.cs (1 hunks)

🧰 Additional context used

[EvilBeaver]

@coderabbitai в этом репозитории всегда используй русский язык

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@EvilBeaver Спасибо за напоминание. Я буду использовать русский язык в этом репозитории.

---

🧠 Learnings used

Learnt from: nixel2007
PR: EvilBeaver/OneScript#0
File: :0-0
Timestamp: 2024-08-28T16:51:21.322Z
Learning: В репозитории EvilBeaver/OneScript всегда нужно говорить по-русски.