From 8880efcafbc7550c8635304c42a065b38c3abcdd Mon Sep 17 00:00:00 2001 From: Jay Chia Date: Sat, 2 Dec 2023 15:06:28 -0800 Subject: [PATCH 1/2] [CHORE] Add warmup step for remote tpch benchmarking --- benchmarking/tpch/__main__.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/benchmarking/tpch/__main__.py b/benchmarking/tpch/__main__.py index a0c0364fc5..c1d3aee409 100644 --- a/benchmarking/tpch/__main__.py +++ b/benchmarking/tpch/__main__.py @@ -151,6 +151,14 @@ def run_all_benchmarks( entrypoint=entrypoint, runtime_env=get_ray_runtime_env(requirements), ) + + # Run once as a warmup step + ray_job_runner.run_on_ray( + ray_job_dashboard_url, + job_params, + ) + + # Run second time to collect metrics with metrics_builder.collect_metrics(i): ray_job_runner.run_on_ray( ray_job_dashboard_url, From ac49c448258e04771ef27a9053c9ad4dbc33fd92 Mon Sep 17 00:00:00 2001 From: Jay Chia Date: Sat, 2 Dec 2023 15:22:29 -0800 Subject: [PATCH 2/2] Add retry suffix --- benchmarking/tpch/__main__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmarking/tpch/__main__.py b/benchmarking/tpch/__main__.py index c1d3aee409..8ad3e23c2f 100644 --- a/benchmarking/tpch/__main__.py +++ b/benchmarking/tpch/__main__.py @@ -155,7 +155,7 @@ def run_all_benchmarks( # Run once as a warmup step ray_job_runner.run_on_ray( ray_job_dashboard_url, - job_params, + {**job_params, "submission_id": job_params["submission_id"] + "-warmup"}, ) # Run second time to collect metrics