Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimizer] Low hanging fruit: Limit->Limit #1321

Closed
xcharleslin opened this issue Aug 29, 2023 · 1 comment
Closed

[Optimizer] Low hanging fruit: Limit->Limit #1321

xcharleslin opened this issue Aug 29, 2023 · 1 comment

Comments

@xcharleslin
Copy link
Contributor

We don't currently fuse limits:

>>> daft.from_pydict({"a": [1, 2, 3, 4, 5]}).limit(4).limit(3).explain(show_optimized=True)
┌─GlobalLimit
│    output=[col(a)]
│    num=3
│    partitioning={'by': None, 'num_partitions': 1, 'scheme': PartitionScheme.Unknown}
│
├──LocalLimit
│    output=[col(a)]
│    num=3
│    partitioning={'by': None, 'num_partitions': 1, 'scheme': PartitionScheme.Unknown}
│
├──GlobalLimit
│    output=[col(a)]
│    num=4
│    partitioning={'by': None, 'num_partitions': 1, 'scheme': PartitionScheme.Unknown}
│
├──LocalLimit
│    output=[col(a)]
│    num=4
│    partitioning={'by': None, 'num_partitions': 1, 'scheme': PartitionScheme.Unknown}
│
└──InMemoryScan
     output=[col(a)]
     cache_id='2218181262134c9f99746c2052d611bf'
     partitioning={'by': None, 'num_partitions': 1, 'scheme': PartitionScheme.Unknown}
@samster25
Copy link
Member

fixed by: #1730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants