From d23e1671fce776cd4bef921e120cb3397aced422 Mon Sep 17 00:00:00 2001 From: Kevin Wang Date: Thu, 21 Nov 2024 18:00:27 -0800 Subject: [PATCH] improve docs --- src/daft-dsl/src/resolve_expr/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/daft-dsl/src/resolve_expr/mod.rs b/src/daft-dsl/src/resolve_expr/mod.rs index e0e94562c8..9474e707be 100644 --- a/src/daft-dsl/src/resolve_expr/mod.rs +++ b/src/daft-dsl/src/resolve_expr/mod.rs @@ -220,10 +220,10 @@ fn expand_wildcards( /// - sum(col("a")) + col("b") when "b" is a group by key /// /// Not allowed: -/// - col("a") +/// - col("a") when "a" is not a group by key /// - not an aggregation /// - sum(col("a")) + col("b") when "b" is not a group by key -/// - not all branches are aggregations +/// - not all branches are aggregations, literals, or group by keys fn has_single_agg_layer(expr: &ExprRef, groupby: &HashSet) -> bool { groupby.contains(expr) || match expr.as_ref() {