diff --git a/docs/source/api_docs/creation.rst b/docs/source/api_docs/creation.rst index ad5b76ec96..b02b3ee3a0 100644 --- a/docs/source/api_docs/creation.rst +++ b/docs/source/api_docs/creation.rst @@ -102,17 +102,6 @@ Delta Lake read_delta_lake -In-memory ---------- - -Arrow -~~~~~ - -.. autosummary:: - :nosignatures: - :toctree: doc_gen/io_functions - - read_sql Integrations ------------ @@ -136,3 +125,12 @@ Dask :toctree: doc_gen/io_functions from_dask_dataframe + +Databases +~~~~~~~~~ + +.. autosummary:: + :nosignatures: + :toctree: doc_gen/io_functions + + read_sql \ No newline at end of file diff --git a/src/daft-dsl/src/lit.rs b/src/daft-dsl/src/lit.rs index 25ffbf3e15..983029e80c 100644 --- a/src/daft-dsl/src/lit.rs +++ b/src/daft-dsl/src/lit.rs @@ -222,15 +222,13 @@ impl LiteralValue { Utf8(val) => format!("'{}'", val).into(), Binary(val) => format!("x'{}'", val.len()).into(), Date(val) => format!("DATE '{}'", display_date32(*val)).into(), - // TODO(Colin): Reading time from Postgres is parsed as Time(Nanoseconds), while from MySQL it is parsed as Duration(Microseconds) - // Need to fix our time comparison code to handle this. - Time(..) => None, Timestamp(val, tu, tz) => format!( "TIMESTAMP '{}'", display_timestamp(*val, tu, tz).replace('T', " ") ) .into(), - Series(..) => None, + // TODO(Colin): Implement the rest of the types in future work for SQl pushdowns. + Decimal(..) | Series(..) | Time(..) => None, #[cfg(feature = "python")] Python(..) => None, }