Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How safe is node-unzip #105

Open
ghost opened this issue Apr 28, 2017 · 2 comments
Open

How safe is node-unzip #105

ghost opened this issue Apr 28, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 28, 2017 •
edited by ghost
Loading

Directory travel issue
https://github.com/ptoomey3/evilarc
https://labs.neohapsis.com/2009/04/21/directory-traversal-in-archives/

Zip bomb
https://www.reddit.com/r/todayilearned/comments/10yniw/til_there_is_a_zip_bomb_called_42zip_that_is_only/

https://en.wikipedia.org/wiki/Zip_bomb

Is there any option to limit only for zip files not to use tar gz ... and archives files limit ?
What happens when somebody create 5 million dirs and empty files ZIP file ?
@ZJONSSON
Copy link

ZJONSSON commented Apr 29, 2017 •
edited
Loading

Interesting question - node-upzip (and unzipper.parse()) stream the source file from start to finish so it is hard to see how recursive loops could be formed. @Dawjan did you perform any test yet?

@ghost
Copy link
Author

ghost commented Apr 29, 2017

get response from yauzl same question and has more security options: thejoshwolfe/yauzl#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZJONSSON