Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timings are supposedly deprecated #73

Open
LinusLeonard opened this issue Dec 3, 2023 · 4 comments
Open

Timings are supposedly deprecated #73

LinusLeonard opened this issue Dec 3, 2023 · 4 comments

Comments

@LinusLeonard
Copy link

LinusLeonard commented Dec 3, 2023

Hello. Getting this in my 1.20.2 Paper server log when running 1.5.0-pre2:

[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Commands' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re list' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re info' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re cancel' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re help' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re bid' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re renewrent' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re exitoffer' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re exitoffer accept' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re exitoffer create' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re exitoffer cancel' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov
[12:31:16 WARN]: Plugin 'RealEstate' is creating timing 'Command: re exitoffer refuse' - this is deprecated behavior, please report it to the authors: EtienneDx, DmitryRendov

No idea what it means though :)

@EtienneDx
Copy link
Owner

Thanks for the report, I haven't had the chance to get any work done on RealEstate in a while so I'm actually surprised it runs at all on ^^'
Maybe @tadhunt can be of some help here, he's the latest dev to have worked on it

@LinusLeonard
Copy link
Author

Heh, it actually works pretty well overall. There are some small issues connected to Minecraft 1.20 and the fact that you can edit signs by just right clicking them in Minecraft Vanilla, but other plugins seem to have similar issues with this new behavior as well, such as GriefPrevention.

@tadhunt
Copy link
Contributor

tadhunt commented Dec 9, 2023

I fixed sign edit on my fork Oct 20, but haven't had a chance to contribute it back. If you want to try my version it's here: https://github.com/tadhunt/RealEstate/releases. I also fixed an ACF issue. I'll try to get these into PRs sometime next week.

I haven't fixed the deprecation warnings yet, since they're not errors 🤣

@LinusLeonard
Copy link
Author

Cool, I'll try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants