Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing style.css file to initial download #545

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: add missing style.css file to initial download #545

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bddbe75
fix: add missing style.css file to initial download
sagewall Nov 25, 2024
8de4037
chore: add comment
sagewall Nov 25, 2024
bf1bcb7
ci: add zip files
github-actions[bot] Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ...nent-samples/map-components/tutorials/create-a-web-app-using-components-initial/style.css
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment on why this is empty if that's intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree it's a strange commit. style.css is intended to be included in the initial download starter project as a blank file. It's imported in starter main.js and leads to build errors and confusion where the tutorial assumes the empty file exists. I guess we could consider editing the tutorial to create the file but this seems like the easier path forward for now is to add the empty style.css file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe added a css comment to the file saying that styles should be added here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 😃

Empty file.