Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing style.css file to initial download #545

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

sagewall
Copy link
Contributor

The create a web app using components initial download is missing the style.css file. This PR adds the missing blank file.

@sagewall sagewall added the draft Pull requests that are a work in progress label Nov 25, 2024
@sagewall sagewall requested review from bsvensson and dasa November 25, 2024 16:22
@sagewall sagewall self-assigned this Nov 25, 2024
@sagewall
Copy link
Contributor Author

This is ready for review, the draft tag is just there to prevent the zips from being generated for now

Copy link
Member

@dasa dasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file is empty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment on why this is empty if that's intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree it's a strange commit. style.css is intended to be included in the initial download starter project as a blank file. It's imported in starter main.js and leads to build errors and confusion where the tutorial assumes the empty file exists. I guess we could consider editing the tutorial to create the file but this seems like the easier path forward for now is to add the empty style.css file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe added a css comment to the file saying that styles should be added here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 😃

@sagewall sagewall removed the draft Pull requests that are a work in progress label Nov 25, 2024
@sagewall sagewall merged commit 68e2604 into main Nov 25, 2024
1 check passed
@sagewall sagewall deleted the sagewall-missing-style branch November 25, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants