chore(vite): replace vite-ts sample with vanilla JS (#529)

* chore(vite): replace vite-ts sample with vanilla JS vite * Bump Vite version * Add favicon shortcut * ci: add zip files * ci: analyze core esm sample builds --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Esri · Aug 14, 2024 · 80adb84 · 80adb84
1 parent d4200bd
commit 80adb84
Show file tree

Hide file tree

Showing 46 changed files with 29 additions and 42 deletions.
diff --git a/core-samples/.metrics/4.30.0.csv b/core-samples/.metrics/4.30.0.csv
@@ -1,7 +1,7 @@
 Sample,Build size (MB),Build file count,Main bundle file,Main bundle size (MB),Main bundle gzipped size (MB),Main bundle brotli compressed size (MB),Load time (ms),Total runtime (ms),Loaded size (MB),Total JS requests,Total JS size (MB),Total HTTP requests,JS heap size (MB)
-esbuild 0.21.4,8.81,741,index.js,0.28,0.07,0.06,5939,19350,5.29,412,3.70,514,28.86
-Angular 18.0.0,9.07,743,chunk-YBOAW74C.js,0.67,0.20,0.17,6205,19237,5.53,413,3.91,518,37.39
-React 18.3.1,8.62,455,index-DOxvg1k6.js,1.49,0.42,0.34,5446,18866,5.39,173,3.79,277,25.23
-Vue 3.4.27,8.53,455,index-DLhlUJ_R.js,1.41,0.40,0.33,5919,18931,5.30,173,3.71,274,27.86
-Rollup 4.18.0,8.32,454,main.js,1.31,0.36,0.29,5589,19010,5.16,173,3.55,276,31.37
-Webpack 5.91.0,10.00,308,index.js,1.43,0.39,0.31,5770,19163,5.67,72,4.07,176,30.54
+esbuild 0.21.4,8.82,742,index.js,0.28,0.07,0.06,6476,19923,5.31,413,3.71,517,26.79
+Angular 18.0.0,9.09,744,chunk-5FWIIEIX.js,0.67,0.20,0.17,6566,20093,5.54,414,3.92,518,27.02
+React 18.3.1,8.63,455,index-B7T79Qu8.js,1.49,0.42,0.35,6029,19434,5.40,173,3.80,278,22.57
+Vue 3.4.27,8.54,455,index-CSsgr1EI.js,1.41,0.40,0.33,6296,19302,5.32,173,3.71,277,28.27
+Rollup 4.18.0,8.33,454,main.js,1.31,0.36,0.29,5962,19378,5.17,173,3.56,276,26.87
+Webpack 5.91.0,10.01,308,index.js,1.43,0.39,0.31,6825,19841,5.68,72,4.08,176,27.12
diff --git a/core-samples/README.md b/core-samples/README.md
@@ -17,7 +17,7 @@ You can use these links to download individual samples:
 * [React/Vite](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-react.zip)
 * [Rollup.js (no framework)](https://esri.github.io/jsapi-resources/zips/core-sample-rollup.zip)
 * [Vue.js/Vite](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-vue.zip)
-* [Vite/TypeScript](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-vite-ts.zip)
+* [Vite](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-vite.zip)
 * [Webpack (no framework)](https://esri.github.io/jsapi-resources/zips/core-sample-webpack.zip)
 
 ## Get Started

diff --git a/core-samples/jsapi-vite-ts/public/vite.svg b/core-samples/jsapi-vite-ts/public/vite.svg
diff --git a/core-samples/jsapi-vite-ts/tsconfig.json b/core-samples/jsapi-vite-ts/tsconfig.json
diff --git a/core-samples/jsapi-vite-ts/.gitignore → core-samples/jsapi-vite/.gitignore b/core-samples/jsapi-vite-ts/.gitignore → core-samples/jsapi-vite/.gitignore
diff --git a/core-samples/jsapi-vite-ts/README.md → core-samples/jsapi-vite/README.md b/core-samples/jsapi-vite-ts/README.md → core-samples/jsapi-vite/README.md
@@ -1,10 +1,10 @@
-# ArcGIS Maps SDK for JavaScript with Vite and TypeScript
+# ArcGIS Maps SDK for JavaScript with Vite
 
-This sample demonstrates how to use [@arcgis/core](https://www.npmjs.com/package/@arcgis/core) ES modules with [Vite](https://vitejs.dev/).
+This sample demonstrates how to use [@arcgis/core](https://www.npmjs.com/package/@arcgis/core) ES modules with [Vite](https://vitejs.dev/) without a framework.
 
 ## Get Started
 
-📁 **[Click here to download this directory as a ZIP file](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-vite-ts.zip)** 📁
+📁 **[Click here to download this directory as a ZIP file](https://esri.github.io/jsapi-resources/zips/core-sample-jsapi-vite.zip)** 📁
 
 Run `npm install` and then start adding modules.
 

diff --git a/core-samples/jsapi-vite-ts/index.html → core-samples/jsapi-vite/index.html b/core-samples/jsapi-vite-ts/index.html → core-samples/jsapi-vite/index.html
@@ -2,12 +2,12 @@
 <html lang="en">
   <head>
     <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <link rel="icon" href="data:;base64,=" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>ArcGIS JS API - Vite + TS</title>
+    <title>ArcGIS JS API - Vite</title>
   </head>
   <body>
     <div id="viewDiv"></div>
-    <script type="module" src="/src/main.ts"></script>
+    <script type="module" src="/src/main.js"></script>
   </body>
 </html>
diff --git a/core-samples/jsapi-vite-ts/package.json → core-samples/jsapi-vite/package.json b/core-samples/jsapi-vite-ts/package.json → core-samples/jsapi-vite/package.json
@@ -1,16 +1,15 @@
 {
-  "name": "jsapi-vite-ts",
+  "name": "jsapi-vite",
   "private": true,
   "version": "0.0.0",
   "type": "module",
   "scripts": {
     "dev": "vite",
-    "build": "tsc && vite build",
+    "build": "vite build",
     "preview": "vite preview"
   },
   "devDependencies": {
-    "typescript": "^5.4.5",
-    "vite": "^5.2.12"
+    "vite": "^5.4.0"
   },
   "dependencies": {
     "@arcgis/core": "~4.30.0"

diff --git a/core-samples/jsapi-vite-ts/src/main.ts → core-samples/jsapi-vite/src/main.js b/core-samples/jsapi-vite-ts/src/main.ts → core-samples/jsapi-vite/src/main.js
@@ -12,7 +12,7 @@ const webmap = new WebMap({
 });
 
 const view = new MapView({
-  container:"viewDiv",
+  container: "viewDiv",
   map: webmap
 });
 

diff --git a/core-samples/jsapi-vite-ts/src/style.css → core-samples/jsapi-vite/src/style.css b/core-samples/jsapi-vite-ts/src/style.css → core-samples/jsapi-vite/src/style.css
diff --git a/core-samples/jsapi-vite/vite.config.js b/core-samples/jsapi-vite/vite.config.js
@@ -0,0 +1,12 @@
+import { defineConfig } from "vite";
+
+const config = {
+  build: {
+    chunkSizeWarningLimit: 1500
+  },
+  server: {
+    open: true
+  }
+};
+
+export default defineConfig(config);
diff --git a/zips/charts-components-sample-angular.zip b/zips/charts-components-sample-angular.zip
diff --git a/zips/charts-components-sample-cdn.zip b/zips/charts-components-sample-cdn.zip
diff --git a/zips/charts-components-sample-react.zip b/zips/charts-components-sample-react.zip
diff --git a/zips/charts-components-sample-vite.zip b/zips/charts-components-sample-vite.zip
diff --git a/zips/charts-components-sample-vue.zip b/zips/charts-components-sample-vue.zip
diff --git a/zips/charts-components-sample-webpack.zip b/zips/charts-components-sample-webpack.zip
diff --git a/zips/charts-components-tutorial-charts-components-with-map-components-initial.zip b/zips/charts-components-tutorial-charts-components-with-map-components-initial.zip
diff --git a/zips/charts-components-tutorial-charts-components-with-map-components-solution.zip b/zips/charts-components-tutorial-charts-components-with-map-components-solution.zip
diff --git a/zips/coding-components-sample-angular.zip b/zips/coding-components-sample-angular.zip
diff --git a/zips/coding-components-sample-cdn.zip b/zips/coding-components-sample-cdn.zip
diff --git a/zips/coding-components-sample-react.zip b/zips/coding-components-sample-react.zip
diff --git a/zips/coding-components-sample-vite.zip b/zips/coding-components-sample-vite.zip
diff --git a/zips/coding-components-sample-vue.zip b/zips/coding-components-sample-vue.zip
diff --git a/zips/coding-components-sample-webpack.zip b/zips/coding-components-sample-webpack.zip
diff --git a/zips/core-sample-esbuild.zip b/zips/core-sample-esbuild.zip
diff --git a/zips/core-sample-jsapi-angular-cli.zip b/zips/core-sample-jsapi-angular-cli.zip
diff --git a/zips/core-sample-jsapi-custom-ui.zip b/zips/core-sample-jsapi-custom-ui.zip
diff --git a/zips/core-sample-jsapi-custom-workers.zip b/zips/core-sample-jsapi-custom-workers.zip
diff --git a/zips/core-sample-jsapi-deno.zip b/zips/core-sample-jsapi-deno.zip
diff --git a/zips/core-sample-jsapi-esm-cdn.zip b/zips/core-sample-jsapi-esm-cdn.zip
diff --git a/zips/core-sample-jsapi-node.zip b/zips/core-sample-jsapi-node.zip
diff --git a/zips/core-sample-jsapi-oauth.zip b/zips/core-sample-jsapi-oauth.zip
diff --git a/zips/core-sample-jsapi-react.zip b/zips/core-sample-jsapi-react.zip
diff --git a/zips/core-sample-jsapi-vite.zip b/zips/core-sample-jsapi-vite.zip
diff --git a/zips/core-sample-jsapi-vue.zip b/zips/core-sample-jsapi-vue.zip
diff --git a/zips/core-sample-rollup.zip b/zips/core-sample-rollup.zip
diff --git a/zips/core-sample-webpack.zip b/zips/core-sample-webpack.zip
diff --git a/zips/map-component-sample-angular.zip b/zips/map-component-sample-angular.zip
diff --git a/zips/map-component-sample-cdn.zip b/zips/map-component-sample-cdn.zip
diff --git a/zips/map-component-sample-react.zip b/zips/map-component-sample-react.zip
diff --git a/zips/map-component-sample-vite.zip b/zips/map-component-sample-vite.zip
diff --git a/zips/map-component-sample-vue.zip b/zips/map-component-sample-vue.zip
diff --git a/zips/map-component-sample-webpack.zip b/zips/map-component-sample-webpack.zip
diff --git a/zips/map-components-tutorial-create-a-web-app-using-components-initial.zip b/zips/map-components-tutorial-create-a-web-app-using-components-initial.zip
diff --git a/zips/map-components-tutorial-create-a-web-app-using-components-solution.zip b/zips/map-components-tutorial-create-a-web-app-using-components-solution.zip