From 02249d9d36481414f849a35f22a6da033b9fa60d Mon Sep 17 00:00:00 2001
From: Tom Wayson <tom@tomwayson.com>
Date: Fri, 30 Mar 2018 12:45:55 -0700
Subject: [PATCH] treat arcgis-rest-js libraries as external

---
 README.md                            | 5 ++++-
 docs/index.html                      | 3 +++
 packages/cedar-amcharts/CHANGELOG.md | 4 ++++
 packages/cedar/profiles/base.js      | 4 ++++
 4 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 46f3dc1e..e0e21744 100644
--- a/README.md
+++ b/README.md
@@ -41,6 +41,9 @@ You can load Cedar and its dependencies by including script tags that point to t
 <script src="https://www.amcharts.com/lib/3/amcharts.js"></script>
 <!-- in this case, we only need bar charts, so we'll load the appropriate amCharts script -->
 <script src="https://www.amcharts.com/lib/3/serial.js"></script>
+<!-- load the arcgis-rest-js scripts -->
+<script src="https://unpkg.com/@esri/arcgis-rest-request@1.1.1/dist/umd/arcgis-rest-request.umd.js"></script>
+<script src="https://unpkg.com/@esri/arcgis-rest-feature-service@1.1.1/dist/umd/arcgis-rest-feature-service.umd.js"></script>
 <!-- optionally load an amcharts theme; cedar provides a calcite theme -->
 <script src="https://unpkg.com/@esri/cedar/dist/umd/themes/amCharts/calcite.js"></script>
 <!-- load cedar -->
@@ -155,7 +158,7 @@ To run tests continually for any package as you update it's soruce code, `cd` in
 
 ### Dependencies
 
-Cedar currently uses the [amCharts JavaScripts Charts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. You will need to include this along with cedar in your application.
+Cedar is a very thin wrapper around other libraries that do the heavy lifting. Cedar uses the [amCharts JavaScripts Charts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. Cedar also uses [@esri/arcgis-rest-feature-service](https://esri.github.io/arcgis-rest-js/api/feature-service/) and [@esri/arcgis-rest-request](https://esri.github.io/arcgis-rest-js/api/request/) to query feature data. You will need to include these libraries along with cedar in your application. If you [install cedar using npm or yarn](#installing-cedar) these libraries will be installed for you, but you will have to make sure that your module bundler can resolve and include them in your application. If you are loading cedar from the CDN, please refer to the [loading cedar](#loading-cedar) section above for the `<script>` tags that you will need to include.
 
 Cedar supports the [same browsers as ArcGIS Online](https://doc.arcgis.com/en/arcgis-online/reference/browsers.htm), however you may need to include polyfills for [`fetch`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch) and [`Promise`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise), if your application has to support browers that don't support [fetch](https://caniuse.com/#search=fetch) or [Promise](https://caniuse.com/#search=promise) (i.e. IE or older versions of Safari/Android).
 
diff --git a/docs/index.html b/docs/index.html
index 68dfb17f..607a9598 100644
--- a/docs/index.html
+++ b/docs/index.html
@@ -81,6 +81,9 @@ <h3>Chart Type</h3>
   <!-- optioinally load the amcharts plugin to export the chart as and image or table -->
   <script src="https://www.amcharts.com/lib/3/plugins/export/export.min.js"></script>
   <link rel="stylesheet" href="https://www.amcharts.com/lib/3/plugins/export/export.css" type="text/css" media="all" />
+  <!-- load the arcgis-rest-js scripts -->
+  <script src="https://unpkg.com/@esri/arcgis-rest-request@1.1.1/dist/umd/arcgis-rest-request.umd.js"></script>
+  <script src="https://unpkg.com/@esri/arcgis-rest-feature-service@1.1.1/dist/umd/arcgis-rest-feature-service.umd.js"></script>
   <!-- optionally load calcite theme -->
   <script src="./scripts/themes/amCharts/calcite.js"></script>
   <!-- load cedar -->
diff --git a/packages/cedar-amcharts/CHANGELOG.md b/packages/cedar-amcharts/CHANGELOG.md
index 9d87215d..52084781 100644
--- a/packages/cedar-amcharts/CHANGELOG.md
+++ b/packages/cedar-amcharts/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Changed
+- treat arcgis libraries as external
+
 ## [1.0.0-beta.3]
 ### Added
 - legend.position determines the location (top, bottom, right, left) of a chart legend
diff --git a/packages/cedar/profiles/base.js b/packages/cedar/profiles/base.js
index 324ee821..4e82fd07 100644
--- a/packages/cedar/profiles/base.js
+++ b/packages/cedar/profiles/base.js
@@ -13,6 +13,10 @@ export default {
   entry: 'dist/esm/index.js',
   moduleName: 'cedar',
   format: 'umd',
+  external: ['@esri/arcgis-rest-feature-service'],
+  globals: {
+    '@esri/arcgis-rest-feature-service': 'arcgisRest'
+  },
   // NOTE: using node resolve to bundle an older version of deepmerge
   // if we move to latest, we _may_ want to make that external instead
   plugins: [json(), resolve()],