diff --git a/README.md b/README.md index 46f3dc1e..e0e21744 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,9 @@ You can load Cedar and its dependencies by including script tags that point to t + + + @@ -155,7 +158,7 @@ To run tests continually for any package as you update it's soruce code, `cd` in ### Dependencies -Cedar currently uses the [amCharts JavaScripts Charts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. You will need to include this along with cedar in your application. +Cedar is a very thin wrapper around other libraries that do the heavy lifting. Cedar uses the [amCharts JavaScripts Charts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. Cedar also uses [@esri/arcgis-rest-feature-service](https://esri.github.io/arcgis-rest-js/api/feature-service/) and [@esri/arcgis-rest-request](https://esri.github.io/arcgis-rest-js/api/request/) to query feature data. You will need to include these libraries along with cedar in your application. If you [install cedar using npm or yarn](#installing-cedar) these libraries will be installed for you, but you will have to make sure that your module bundler can resolve and include them in your application. If you are loading cedar from the CDN, please refer to the [loading cedar](#loading-cedar) section above for the ` + + + diff --git a/packages/cedar-amcharts/CHANGELOG.md b/packages/cedar-amcharts/CHANGELOG.md index 9d87215d..52084781 100644 --- a/packages/cedar-amcharts/CHANGELOG.md +++ b/packages/cedar-amcharts/CHANGELOG.md @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] +### Changed +- treat arcgis libraries as external + ## [1.0.0-beta.3] ### Added - legend.position determines the location (top, bottom, right, left) of a chart legend diff --git a/packages/cedar/profiles/base.js b/packages/cedar/profiles/base.js index 324ee821..4e82fd07 100644 --- a/packages/cedar/profiles/base.js +++ b/packages/cedar/profiles/base.js @@ -13,6 +13,10 @@ export default { entry: 'dist/esm/index.js', moduleName: 'cedar', format: 'umd', + external: ['@esri/arcgis-rest-feature-service'], + globals: { + '@esri/arcgis-rest-feature-service': 'arcgisRest' + }, // NOTE: using node resolve to bundle an older version of deepmerge // if we move to latest, we _may_ want to make that external instead plugins: [json(), resolve()],