Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: BasemapGallery fails to load default Basemaps in WPF #586

Merged
merged 2 commits into from
Jul 25, 2024
Merged

BugFix: BasemapGallery fails to load default Basemaps in WPF #586

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a7b43
Optimize BasemapGallery initialization
prathameshnarkhede Jul 25, 2024
89d292a
Initialize AvailableBasemaps and improve load check
prathameshnarkhede Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Toolkit/Toolkit.UI.Controls/BasemapGallery/BasemapGallery.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public BasemapGallery()
_controller = new BasemapGalleryController();
DefaultStyleKey = typeof(BasemapGallery);
SizeChanged += BasemapGallerySizeChanged;
AvailableBasemaps = new ObservableCollection<BasemapGalleryItem>();
_controller.PropertyChanged += HandleControllerPropertyChanged;
Loaded += BasemapGallery_Loaded;
}
Expand All @@ -52,7 +51,7 @@ private async void BasemapGallery_Loaded(object? sender, RoutedEventArgs e)
{
// Unsubscribe from the Loaded event to ensure this only runs once.
Loaded -= BasemapGallery_Loaded;

if (AvailableBasemaps is null)
{
await _controller.LoadFromDefaultPortal();
Expand Down
Loading