BugFix: BasemapGallery fails to load default Basemaps in WPF #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant initialization of `AvailableBasemaps` in the `BasemapGallery` constructor. Added a null check in `BasemapGallery_Loaded` to initialize `AvailableBasemaps` only if it is null, calling `_controller.LoadFromDefaultPortal()` asynchronously if needed. This change prevents unnecessary initialization and allows for external setting of `AvailableBasemaps` before the control is loaded.
mstefarov
approved these changes
Jul 25, 2024
dotMorten
requested changes
Jul 25, 2024
Add initialization flag for BasemapGallery collection
dotMorten
approved these changes
Jul 25, 2024
dotMorten
deleted the
pratham/12695-bug-change-basemap-sample-appears-fully-blank-after-launching-in-both-wpf-public-sample-viewers
branch
dotMorten
added a commit
that referenced
this pull request
Aug 1, 2024
* Set up v.next branch * WPF/MAUI: FeatureForm attachments support (#581) * Added missing trimming attribute * Move code for getting parent to common location * Add null-check * Improve app theming and theme testing * Adds support for the barcode input field (#583) * Adds support for the barcode input field * Added support to override URL clicks in PopupViewer (#584) * Added support to override URL clicks in PopupViewer * Added samples for reference * Refactor PopupViewer and event handling * Refactor hyperlink event handling and cleanup - Corrected the event name from `HyperLinkClicked` to `HyperlinkClicked` in both XAML and code-behind files for consistency and to meet case sensitivity requirements. * Refactor GetPopupViewerParent to generic * Refactor GetParent<T> generic constraint * Broaden type check in Tapped event handler * Refine type checks and adjust imports * Refactor PopupViewer parent traversal logic * Add discard method to featureform that ensures the form is fully reset by re-evaluating expressions All add Finish method for consistency * Improve discards and avoiding cascading evaluations * Add barcode scanner example to maui sample using ZXing * Refetch attachment on discard * Fix null warning * Add error border below text field (#585) Ensures on catalyst that the textfield isn't blocked form clicking when there's an error * BugFix: BasemapGallery fails to load default Basemaps in WPF (#586) * Optimize BasemapGallery initialization Removed redundant initialization of `AvailableBasemaps` in the `BasemapGallery` constructor. Added a null check in `BasemapGallery_Loaded` to initialize `AvailableBasemaps` only if it is null, calling `_controller.LoadFromDefaultPortal()` asynchronously if needed. This change prevents unnecessary initialization and allows for external setting of `AvailableBasemaps` before the control is loaded. * Initialize AvailableBasemaps and improve load check Add initialization flag for BasemapGallery collection * Raise hyperlink event for field links #576 --------- Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Prathamesh Narkhede <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The BasemapGallery used to be fully empty when default Basemaps are loaded.
It also preserved loading custom Basemaps into the BasemapGallery.
BasemapGallery with Default Basemaps:
BasemapGallery with Custom Basemaps: