Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a GeoView controller to help with common MVVM challenges #528

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

dotMorten
Copy link
Member

@dotMorten dotMorten commented Oct 12, 2023

Helper class for allowing you to perform view operations on the MapView from your ViewModel, through an attached proxy-object that ensures you keep VM and View separated.

Design choices:

  • Basic controller for most common operations like setting viewpoint, performing identify and showing callouts. No specific mapview or sceneview operation.
  • Extensible, so you can add your own custom map and scene operations, or interface for allowing testing (see WPF sample)
  • No events exposed - use EventToCommand or similar already established approaches to forward view events back to the view model (see samples)

@dotMorten dotMorten requested a review from mstefarov October 12, 2023 19:04
@dotMorten dotMorten self-assigned this Oct 12, 2023
@dotMorten dotMorten marked this pull request as ready for review October 17, 2023 18:20
@dotMorten dotMorten requested a review from gdestigter October 24, 2023 20:45
src/Toolkit/Toolkit/GeoViewController.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit/GeoViewController.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit/GeoViewController.cs Show resolved Hide resolved
src/Toolkit/Toolkit/GeoViewController.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit/GeoViewController.cs Outdated Show resolved Hide resolved
src/Toolkit/Toolkit/GeoViewController.cs Outdated Show resolved Hide resolved
@dotMorten dotMorten requested a review from mstefarov November 7, 2023 22:10
@dotMorten dotMorten merged commit 7c0b0b7 into main Nov 8, 2023
1 check passed
@dotMorten dotMorten deleted the GeoViewController branch November 8, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants