Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nitro-contracts CI #157

Open
sveitser opened this issue Jul 22, 2024 · 0 comments
Open

Fix nitro-contracts CI #157

sveitser opened this issue Jul 22, 2024 · 0 comments
Assignees
@ImJeremyHe

Comments

@sveitser
Copy link

sveitser commented Jul 22, 2024 •
edited
Loading

Currently the e2e tests are broken because they use the upstream nitro-testnode, we need to use our own fork.

  1. fork https://github.com/OffchainLabs/actions to espresso github (call it offchainlabs-actions, to not confuse it)
  2. add an input testnode-repo that defaults to offchainlabs/nitro-testnode. Use it here https://github.com/OffchainLabs/actions/blob/953e8475606f180ce2b0531d411983ce37f34751/run-nitro-test-node/action.yml#L40
  3. use this action in the nitro-constracts CI
  4. open PR to upstream action repo
  5. switch back to upstream action if/once they merge our PR
zacshowa pushed a commit that referenced this issue Nov 26, 2024
@gzeoneth
Merge pull request #157 from OffchainLabs/oz-audit
0f88cf7 
update yarn audit: OZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImJeremyHe ImJeremyHe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sveitser @ImJeremyHe