Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExplorerHeader should not have the method namespace_ids_for_offset #579

Closed
Ayiga opened this issue May 10, 2024 · 0 comments · Fixed by #580
Closed

ExplorerHeader should not have the method namespace_ids_for_offset #579

Ayiga opened this issue May 10, 2024 · 0 comments · Fixed by #580

Comments

@Ayiga
Copy link
Member

Ayiga commented May 10, 2024

The method namespace_ids_for_offset is intended to get a list of NamespaceIds for a given Transaction offset on a Block Header. Considering implementation details the Block Header doesn't actually have access to this information, based on the discussion here: EspressoSystems/espresso-sequencer#1428 (comment).

Since this method is only utilized for TransactionSummary, TransactionSummary has access to the actual Transaction itself when being constructed, and the implementation details for a Transaction actually has access to its NamespaceId, then we can make this work by creating a trait for the Transaction itself to retrieve its own NamespaceId.

So, we need to remove namespace_ids_for_offset, and create a new trait for a Transaction for use with the Explorer API, that allows us to retrieve the NamespaceId from the transaction itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant