From 78265e08c3c6604dfb5ceccb7644835b5b83b0ff Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:27:00 +0200 Subject: [PATCH 1/6] fix: correct typos and improve clarity in GPU leader startup comments --- scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh b/scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh index cad14d150e..f508e61ef2 100755 --- a/scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh +++ b/scripts/benchmark_scripts/aws_ecs_benchmarks_cdn_gpu.sh @@ -106,7 +106,7 @@ EOF sleep 30 # start leaders need to run on GPU FIRST - # and WAIT for enough time till it registerred at orchestrator + # and WAIT for enough time till it registered at orchestrator # make sure you're able to access the remote nvidia gpu server echo -e "\e[35mGoing to start leaders on remote gpu server $REMOTE_GPU_HOST\e[0m" @@ -165,4 +165,4 @@ done # shut down all related threads echo -e "\e[35mGoing to stop cdn-marshal\e[0m" killall -9 cdn-marshal -# for pid in $(ps -ef | grep "keydb-server" | awk '{print $2}'); do sudo kill -9 $pid; done \ No newline at end of file +# for pid in $(ps -ef | grep "keydb-server" | awk '{print $2}'); do sudo kill -9 $pid; done From 3d18a54cdd47c00cb4d42d98d97d03d3de2ca81c Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:28:34 +0200 Subject: [PATCH 2/6] fix: typos --- crates/macros/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/macros/src/lib.rs b/crates/macros/src/lib.rs index e874468cda..3cdff17fe4 100644 --- a/crates/macros/src/lib.rs +++ b/crates/macros/src/lib.rs @@ -17,7 +17,7 @@ use syn::{ /// description of a crosstest #[derive(derive_builder::Builder, Debug, Clone)] struct CrossTestData { - /// imlementations + /// implementations impls: ExprArray, /// builder impl #[builder(default = "syn::parse_str(\"[SimpleBuilderImplementation]\").unwrap()")] From c51d344a46bf2835e8914e002fd4963f2c256e06 Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:33:00 +0200 Subject: [PATCH 3/6] fix `includs` typo in logic for collecting peer config --- crates/orchestrator/api.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/orchestrator/api.toml b/crates/orchestrator/api.toml index 25fcb2b7c2..7a18fbb193 100644 --- a/crates/orchestrator/api.toml +++ b/crates/orchestrator/api.toml @@ -44,7 +44,7 @@ Supply whether or not we are DA. [route.peer_pubconfig_ready] PATH = ["peer_pub_ready"] DOC = """ -Get whether the node can collect the final config which includs all peer's public config/info like public keys, returns a boolean. +Get whether the node can collect the final config which includes all peer's public config/info like public keys, returns a boolean. """ # POST the updated config with all peers' public keys / configs From 81f686ace776d36b801eb7fe258c0abc61bceef4 Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:35:10 +0200 Subject: [PATCH 4/6] Fix spelling mistake in `transactions` in block return logic --- crates/testing/src/block_builder/simple.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/testing/src/block_builder/simple.rs b/crates/testing/src/block_builder/simple.rs index 63a28d854c..395ba6c016 100644 --- a/crates/testing/src/block_builder/simple.rs +++ b/crates/testing/src/block_builder/simple.rs @@ -238,7 +238,7 @@ where .await; if transactions.is_empty() { - // We don't want to return an empty block if we have no trasnactions, as we would end up + // We don't want to return an empty block if we have no transactions, as we would end up // driving consensus to produce empty blocks extremely quickly when mempool is empty. // Instead, we return no blocks, so that view leader will keep asking for blocks until // either we have something non-trivial to propose, or leader runs out of time to propose, From b3636d864e75c0bb2d2f034eef6d2b4ae3d9e684 Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:37:06 +0200 Subject: [PATCH 5/6] fix typo: `accidently` -> `accidentally` in sealed marker logic --- crates/types/src/simple_vote.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/types/src/simple_vote.rs b/crates/types/src/simple_vote.rs index f5111084b8..ac76131ae3 100644 --- a/crates/types/src/simple_vote.rs +++ b/crates/types/src/simple_vote.rs @@ -324,7 +324,7 @@ impl Committable for ViewSyncCommitData { } } -// impl votable for all the data types in this file sealed marker should ensure nothing is accidently +// impl votable for all the data types in this file sealed marker should ensure nothing is accidentally // implemented for structs that aren't "voteable" impl Voteable for V From 1177f7736b9a2c95bc8b42287e232d5c696708f3 Mon Sep 17 00:00:00 2001 From: leopardracer <136604165+leopardracer@users.noreply.github.com> Date: Fri, 6 Dec 2024 12:38:50 +0200 Subject: [PATCH 6/6] fix spelling mistake in event message --- docs/diagrams/HotShotFlow.drawio | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/diagrams/HotShotFlow.drawio b/docs/diagrams/HotShotFlow.drawio index c6ac0dafb0..734c88ff2e 100644 --- a/docs/diagrams/HotShotFlow.drawio +++ b/docs/diagrams/HotShotFlow.drawio @@ -1937,7 +1937,7 @@ - +