Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix #3

Open
PonteIneptique opened this issue Nov 1, 2017 · 1 comment
Open

To fix #3

PonteIneptique opened this issue Nov 1, 2017 · 1 comment
Assignees

Comments

@PonteIneptique
Copy link
Contributor

PonteIneptique commented Nov 1, 2017

From @hcayless

Looking at https://github.com/lascivaroma/cil004-00000/blob/master/data/cil004-00000/00002/cil004-00000.00002.manfred-lat1.xml

<expan><abbr>d</abbr><ex>uum</ex><abbr>v</abbr></expan><expan><ex>irum</ex></expan>
  1. <lb/> is a line beginning, so the first one should be at the start of the first line.
  2. I wouldn't wrap <gap/>s in <w>, because we don't know what was in them. To be honest, I probably wouldn't use <w> at all, or only in cases where it might be ambiguous whether something was a word or not.
<expan><abbr>d</abbr><ex>uum</ex><abbr>v</abbr></expan><expan><ex>irum</ex></expan>

should be

<expan><abbr>d</abbr><ex>uum</ex><abbr>v</abbr><ex>irum</ex></expan>
  1. In https://github.com/lascivaroma/cil004-00000/blob/master/data/cil004-00000/00002/cil004-00000.00002.manfred-lat1.xml,
ae<supplied reason="lost"><expan><abbr>d</abbr><ex>ilem</ex></expan></supplied>

should be

<expan><abbr>ae<supplied reason="lost">d</supplied></abbr><ex>ilem</ex></expan>
  1. In https://raw.githubusercontent.com/lascivaroma/cil004-00000/master/data/cil004-00000/00082/cil004-00000.00082.manfred-lat1.xml,
o<supplied reason="lost">ro</supplied></w> <w n="6"><supplied
reason="lost"><expan><abbr>v</abbr><ex>os</ex></expan></supplied></w>
<w n="7"><expan><abbr>[f</abbr><ex
cert="low">aciatis</ex><abbr>]</abbr></expan>

should be

o<supplied reason="lost">ro
<expan><abbr>v</abbr><ex>os</ex></expan><expan><abbr>f</abbr><ex
cert="low">aciatis</ex></expan></supplied>

The latter highlights a reason maybe not to do <w>, because things like <supplied> can run across words. If you really want to mark words, you'll need to bridge the gaps in the sliced up with @prev/@next.

@PonteIneptique
Copy link
Contributor Author

For the 5th point, I might be forced to do

 <expan><abbr><supplied reason="lost">f</supplied></abbr><ex cert="low">aciatis</ex></expan>

The question I'd ask is : could you give me an example of prev/next use ? @hcayless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant