Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure printing of wrapped ConcreteRArrays goes through our show #367

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Dec 12, 2024

Avoids issues with printing reshapedarrays and such, since those used getindex

@avik-pal avik-pal merged commit 8b90501 into main Dec 12, 2024
20 of 38 checks passed
@avik-pal avik-pal deleted the ap/fix_print branch December 12, 2024 04:41
jumerckx added a commit to jumerckx/Reactant.jl that referenced this pull request Dec 16, 2024
commit 65e9976
Author: William Moses <[email protected]>
Date:   Sat Dec 14 14:05:03 2024 -0600

    Interp2 (EnzymeAD#365)

    * WIP: kernels

    * more files

    * fix

    * wip

    * wqtmp

    * wip

    * inc

    * continuing

    * wip

    * more work

    * inf rec

    * fix

    * overload working

    * continuing

    * continuing

    * push

    * fix `call_with_reactant_generator` for Julia 1.11 (EnzymeAD#359)

    * conversion

    * continuing

    * Cleanup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * Delete test/cuda.jl

    * fixup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * fix apply

    * indep of change

    * minor fix in name

    * Update utils.jl

    * Interp take 2

    * continuing adentures

    * delcode

    * fix

    * tmp

    * make

    * fix

    * cleanup

    * continuing

    * more working

    * further simplify

    * fx

    * more improvements

    * minus show

    * less prints

    * even fewer

    * confusion

    * tmp

    * force clean

    * force oc

    * clean

    * Rewrite

    * fixup

    * fix

    * fix

    * fix

    * fixup

    * fix

    * wip

    * safe prints

    * fix

    * fix

    * stackoverflow

    * cleanup

    * dyindex

    * rt

    * continue

    * clean

    * fix

    * fix

    * fix

    * fix

    * fixup

    * fix

    * fix

    * capture oc

    * compile perf

    * v1.11 fix

    * other way 'round

    * formatting

    ---------

    Co-authored-by: William Moses <[email protected]>
    Co-authored-by: jumerckx <[email protected]>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: jumerckx <[email protected]>

commit 73899f5
Author: Avik Pal <[email protected]>
Date:   Sat Dec 14 14:58:47 2024 +0530

    fix: include files if they end with .jl (EnzymeAD#377)

commit 9f96c09
Author: Sergio Sánchez Ramírez <[email protected]>
Date:   Fri Dec 13 23:12:43 2024 +0100

    Run CI on aarch64 (EnzymeAD#350)

    * Run CI on aarch64

    * use julia pipeline for aarch64-linux

    * fix var

    * exclude aarch64-linux jobs from github ci

commit b56e661
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 13 08:58:51 2024 +0530

    chore: format code (EnzymeAD#371)

    Co-authored-by: mofeing <[email protected]>

commit 311498b
Author: Anton Oresten <[email protected]>
Date:   Thu Dec 12 05:41:39 2024 +0100

    feat: define outer `repeat` method for `TracedRArray` (EnzymeAD#361)

    * Add repeat method

    * Add repeat tests

    * Update test/basic.jl

    * Update src/TracedRArray.jl

commit 8b90501
Author: Avik Pal <[email protected]>
Date:   Thu Dec 12 10:11:00 2024 +0530

    fix: ensure printing of wrapped ConcreteRArrays goes through our show (EnzymeAD#367)

    * fix: ensure printing of wrapped ConcreteRArrays goes through our show

    * fix: allow wrapped arrays in mapreduce

commit ea97be3
Author: Sergio Sánchez Ramírez <[email protected]>
Date:   Wed Dec 11 22:02:14 2024 +0100

    Ignore versioned manifests
jumerckx added a commit to jumerckx/Reactant.jl that referenced this pull request Dec 16, 2024
commit 65e9976
Author: William Moses <[email protected]>
Date:   Sat Dec 14 14:05:03 2024 -0600

    Interp2 (EnzymeAD#365)

    * WIP: kernels

    * more files

    * fix

    * wip

    * wqtmp

    * wip

    * inc

    * continuing

    * wip

    * more work

    * inf rec

    * fix

    * overload working

    * continuing

    * continuing

    * push

    * fix `call_with_reactant_generator` for Julia 1.11 (EnzymeAD#359)

    * conversion

    * continuing

    * Cleanup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * Delete test/cuda.jl

    * fixup

    * Apply suggestions from code review

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

    * fix apply

    * indep of change

    * minor fix in name

    * Update utils.jl

    * Interp take 2

    * continuing adentures

    * delcode

    * fix

    * tmp

    * make

    * fix

    * cleanup

    * continuing

    * more working

    * further simplify

    * fx

    * more improvements

    * minus show

    * less prints

    * even fewer

    * confusion

    * tmp

    * force clean

    * force oc

    * clean

    * Rewrite

    * fixup

    * fix

    * fix

    * fix

    * fixup

    * fix

    * wip

    * safe prints

    * fix

    * fix

    * stackoverflow

    * cleanup

    * dyindex

    * rt

    * continue

    * clean

    * fix

    * fix

    * fix

    * fix

    * fixup

    * fix

    * fix

    * capture oc

    * compile perf

    * v1.11 fix

    * other way 'round

    * formatting

    ---------

    Co-authored-by: William Moses <[email protected]>
    Co-authored-by: jumerckx <[email protected]>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: jumerckx <[email protected]>

commit 73899f5
Author: Avik Pal <[email protected]>
Date:   Sat Dec 14 14:58:47 2024 +0530

    fix: include files if they end with .jl (EnzymeAD#377)

commit 9f96c09
Author: Sergio Sánchez Ramírez <[email protected]>
Date:   Fri Dec 13 23:12:43 2024 +0100

    Run CI on aarch64 (EnzymeAD#350)

    * Run CI on aarch64

    * use julia pipeline for aarch64-linux

    * fix var

    * exclude aarch64-linux jobs from github ci

commit b56e661
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Dec 13 08:58:51 2024 +0530

    chore: format code (EnzymeAD#371)

    Co-authored-by: mofeing <[email protected]>

commit 311498b
Author: Anton Oresten <[email protected]>
Date:   Thu Dec 12 05:41:39 2024 +0100

    feat: define outer `repeat` method for `TracedRArray` (EnzymeAD#361)

    * Add repeat method

    * Add repeat tests

    * Update test/basic.jl

    * Update src/TracedRArray.jl

commit 8b90501
Author: Avik Pal <[email protected]>
Date:   Thu Dec 12 10:11:00 2024 +0530

    fix: ensure printing of wrapped ConcreteRArrays goes through our show (EnzymeAD#367)

    * fix: ensure printing of wrapped ConcreteRArrays goes through our show

    * fix: allow wrapped arrays in mapreduce

commit ea97be3
Author: Sergio Sánchez Ramírez <[email protected]>
Date:   Wed Dec 11 22:02:14 2024 +0100

    Ignore versioned manifests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants