Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Code (Helper Functions) in Modules #4

Open
imagina opened this issue May 4, 2012 · 2 comments
Open

Duplicated Code (Helper Functions) in Modules #4

imagina opened this issue May 4, 2012 · 2 comments

Comments

@imagina
Copy link
Contributor

imagina commented May 4, 2012

resellerclubmdhosting.php and resellerclubmdhosting.php have the same functions duplicated.

For example: _createCustomer, _get_order_duration_months, etc

I think that functions should be better in a helper file (class?) inside the addon folder.

@viral-patel
Copy link
Contributor

Yes, we are aware of this and currently the code is under review.

We've identified some piece of code which needs to be moved to a function and move the common functions to helper functions file in addon directory.

We're already in process of the changes.

It will soon be pushed.

Keep the feedbacks and suggestions coming.

Thanks

@imagina
Copy link
Contributor Author

imagina commented May 4, 2012

Ok great and thanks for the module. I will be using in it production very soon.

@imagina imagina closed this as completed May 4, 2012
@imagina imagina reopened this May 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants